shark + assertions + llvm2.6 [PATCH] shark IA32

[Xerxes Rånby]

Gary Benson skrev:
> Xerxes Rånby wrote:
>   
>> Den 2009-04-14 15:11, Gary Benson skrev:
>>     
>>> Xerxes Rånby wrote:
>>>       
>>>> I tested building a debuggable shark with assertions enabled using
>>>> the current llvm 2.6 svn trunk on X86.
>>>>
>>>> I have one assertion that fails when running trivial stuff like java
>>>> -version
>>>> I wanted to know your opinion if this IA32_ONLY assertion in
>>>> /openjdk-ecj/hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp:424
>>>> are valid for shark or should i simply ignore it?
>>>>      
>>>>         
>>> That one's definitely important.  If it fails then your stack is
>>> corrupted.
>>>       
>> Thanks, i will look for what corrupts my stack then.
>>
>> Do you know the reason why this assertion is only enabled for IA32 ?
>>
>> Would not all hotspots using shark or not benefit for checking this  
>> assertions as well?
>>     
>
> Hmmm, I'm confused, I thought it was the assertion before the IA32
> one that was firing, but it's not is it.  Are you building on IA32?
> If not, there's something wrong with your build!  But in any case,
> I don't think that IA32_ONLY assertion is valid on Shark, so it
> should be surrounded by an #ifdef SHARK ... #endif // SHARK.
>
> Cheers,
> Gary
>
>   
I was building on a IA32 machine, more precisely i was building shark on a
Intel(R) Core(TM)2 Quad CPU    Q9550  @ 2.83GHz
This is a IA32 CPU in my world so i think the build got that one right.

I have attached a patch against Icedtea6 as a remedy for this problem 
using Shark on IA32

Cheers
Xerxes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: hg_diff_icedtea-ia32-hotspot-shark.patch
Type: text/x-patch
Size: 1183 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090415/01d9e3ea/hg_diff_icedtea-ia32-hotspot-shark.patch