changeset in /hg/icedtea6: 2009-04-29 Gary Benson <gbenson at red...

[Gary Benson]

changeset a37e9b594cb2 in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=a37e9b594cb2
description:
	2009-04-29  Gary Benson  <gbenson at redhat.com>

		* ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp
		(SharkTopLevelBlock::scan_for_traps): Trap on ldc and ldc_w
		when the constant is unresolved.
		(SharkTopLevelBlock::lookup_for_ldc): Rewritten.
		* ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp
		(SharkConstantPool::java_mirror): Add a comment.

diffstat:

3 files changed, 47 insertions(+), 62 deletions(-)
ChangeLog                                               |    9 +
ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp  |    1 
ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp |   99 +++++----------

diffs (144 lines):

diff -r df5a8e49d157 -r a37e9b594cb2 ChangeLog
--- a/ChangeLog	Tue Apr 28 16:53:58 2009 +0200
+++ b/ChangeLog	Wed Apr 29 04:53:32 2009 -0400
@@ -1,3 +1,12 @@ 2009-04-28  Mark Wielaard  <mjw at redhat.c
+2009-04-29  Gary Benson  <gbenson at redhat.com>
+
+	* ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp
+	(SharkTopLevelBlock::scan_for_traps): Trap on ldc and ldc_w
+	when the constant is unresolved.
+	(SharkTopLevelBlock::lookup_for_ldc): Rewritten.
+	* ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp
+	(SharkConstantPool::java_mirror): Add a comment.
+
 2009-04-28  Mark Wielaard  <mjw at redhat.com>
 
 	* tapset/hotspot.stp.in: New systemtap tapset for hotspot.
diff -r df5a8e49d157 -r a37e9b594cb2 ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp
--- a/ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp	Tue Apr 28 16:53:58 2009 +0200
+++ b/ports/hotspot/src/share/vm/shark/sharkConstantPool.cpp	Wed Apr 29 04:53:32 2009 -0400
@@ -116,6 +116,7 @@ Value *SharkConstantPool::java_mirror()
     SharkType::klass_type(),
     "klass_part");
 
+  // XXX should there be a memory barrier before this load?
   return builder()->CreateValueOfStructEntry(
     klass_part,
     in_ByteSize(Klass::java_mirror_offset_in_bytes()),
diff -r df5a8e49d157 -r a37e9b594cb2 ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp
--- a/ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp	Tue Apr 28 16:53:58 2009 +0200
+++ b/ports/hotspot/src/share/vm/shark/sharkTopLevelBlock.cpp	Wed Apr 29 04:53:32 2009 -0400
@@ -46,6 +46,17 @@ void SharkTopLevelBlock::scan_for_traps(
     int index = -1;
 
     switch (bc()) {
+    case Bytecodes::_ldc:
+    case Bytecodes::_ldc_w:
+      if (iter()->is_unresolved_string() || iter()->is_unresolved_klass()) {
+        set_trap(
+          Deoptimization::make_trap_request(
+            Deoptimization::Reason_uninitialized,
+            Deoptimization::Action_reinterpret), bci());
+        return;
+      }
+      break;
+      
     case Bytecodes::_getfield:
     case Bytecodes::_getstatic:
     case Bytecodes::_putfield:
@@ -579,69 +590,33 @@ void SharkTopLevelBlock::release_locked_
 
 Value *SharkTopLevelBlock::lookup_for_ldc()
 {
+  int index = iter()->get_constant_index();
+  constantTag tag = target()->holder()->constant_pool_tag_at(index);
+
   SharkConstantPool constants(this);
-
-  BasicBlock *resolved       = function()->CreateBlock("resolved");
-  BasicBlock *resolved_class = function()->CreateBlock("resolved_class");
-  BasicBlock *unresolved     = function()->CreateBlock("unresolved");
-  BasicBlock *unknown        = function()->CreateBlock("unknown");
-  BasicBlock *done           = function()->CreateBlock("done");
-
-  SwitchInst *switchinst = builder()->CreateSwitch(
-    constants.tag_at(iter()->get_constant_index()),
-    unknown, 5);
-
-  switchinst->addCase(
-    LLVMValue::jbyte_constant(JVM_CONSTANT_String), resolved);
-  switchinst->addCase(
-    LLVMValue::jbyte_constant(JVM_CONSTANT_Class), resolved_class);
-  switchinst->addCase(
-    LLVMValue::jbyte_constant(JVM_CONSTANT_UnresolvedString), unresolved);
-  switchinst->addCase(
-    LLVMValue::jbyte_constant(JVM_CONSTANT_UnresolvedClass), unresolved);
-  switchinst->addCase(
-    LLVMValue::jbyte_constant(JVM_CONSTANT_UnresolvedClassInError),
-    unresolved);
-
-  builder()->SetInsertPoint(resolved);
-  Value *resolved_value = constants.object_at(iter()->get_constant_index());
-  builder()->CreateBr(done);
-
-  builder()->SetInsertPoint(resolved_class);
-  Value *resolved_class_value
-    = constants.object_at(iter()->get_constant_index());
-  resolved_class_value
-    = builder()->CreatePtrToInt(resolved_class_value,
-                                SharkType::intptr_type());
-  resolved_class_value
-    = (builder()->CreateAdd
-       (resolved_class_value,
-        (LLVMValue::intptr_constant
-         (klassOopDesc::klass_part_offset_in_bytes()
-          + Klass::java_mirror_offset_in_bytes()))));
-  // XXX FIXME: We need a memory barrier before this load.
-  resolved_class_value
-    = (builder()->CreateLoad
-       (builder()->CreateIntToPtr
-        (resolved_class_value,
-         PointerType::getUnqual(SharkType::jobject_type()))));
-  builder()->CreateBr(done);
-
-  builder()->SetInsertPoint(unresolved);
-  builder()->CreateUnimplemented(__FILE__, __LINE__);
-  Value *unresolved_value = LLVMValue::null();
-  builder()->CreateBr(done);
-
-  builder()->SetInsertPoint(unknown);
-  builder()->CreateShouldNotReachHere(__FILE__, __LINE__);
-  builder()->CreateUnreachable();
-
-  builder()->SetInsertPoint(done);
-  PHINode *phi = builder()->CreatePHI(SharkType::jobject_type(), "constant");
-  phi->addIncoming(resolved_value, resolved);
-  phi->addIncoming(resolved_class_value, resolved_class);
-  phi->addIncoming(unresolved_value, unresolved);
-  return phi;
+  Value *entry = constants.object_at(index);
+
+  Value *klass_part;
+  switch (tag.value()) {
+  case JVM_CONSTANT_String:
+    return entry;
+
+  case JVM_CONSTANT_Class:
+    klass_part = builder()->CreateAddressOfStructEntry(
+      entry,
+      in_ByteSize(klassOopDesc::klass_part_offset_in_bytes()),
+      SharkType::klass_type(),
+      "klass_part");
+    // XXX FIXME: We need a memory barrier before this load
+    return builder()->CreateValueOfStructEntry(
+      klass_part,
+      in_ByteSize(Klass::java_mirror_offset_in_bytes()),
+      SharkType::oop_type(),
+      "java_mirror");
+
+  default:
+    ShouldNotReachHere();
+  }
 }
 
 Value* SharkTopLevelBlock::lookup_for_field_access()