Some improvements needed on icedtea Java2D renderers.

[Omair Majid]

Hi,

Xerxes Rånby wrote:
> Hello, during bug testing of icedtea6 on various embedded and stationary 
> hardware i have stumbled across some rendering issues of java2d when 
> running under icedtea6.
> 
> Testcase:
> http://java.sun.com/products/java-media/2D/samples/java2demo/Java2Demo.html
> 
> Sourcecode available from:
> http://java.sun.com/products/java-media/2D/samples/java2demo/Java2D.zip

Attaching two patches and adding 2d-dev to cc list to get feedback on 
the patches.

> 
> 5. and 6.  The last two issues are related. the specified joinType are 
> not applyed to lines that gets inserted using closePath.
>    public void drawDemo(int w, int h, Graphics2D g2) {
>        BasicStroke bs = new BasicStroke(bswidth,
>                                    BasicStroke.CAP_BUTT, joinType);
>        GeneralPath p = new GeneralPath();
>        p.moveTo(- w / 4.0f, - h / 12.0f);
>        p.lineTo(+ w / 4.0f, - h / 12.0f);
>        p.lineTo(- w / 6.0f, + h / 4.0f);
>        p.lineTo(+     0.0f, - h / 4.0f);
>        p.lineTo(+ w / 6.0f, + h / 4.0f);
>        p.closePath();                                          //      
> <-----  issue 6: this should have create a correct join. instead a round 
> join are allways used.
>        p.closePath();                                          //      
> <-----  issue 5: this should have create a correct join. the rendering 
> of the start line should
Is the second closePath() supposed to do anything?
>                                                                        
> //                have  been updated when the second closepath was 
> instructed.
>        g2.translate(w/2, h/2);
>        g2.setColor(Color.black);
>        g2.draw(bs.createStrokedShape(p));
>    }
> 

issue5-internal-joint.patch fixes the internal joint on the bottom right 
corner of the star. The external round join issue is fixed by an 
OpenJDK7 patch [1]. This has already been backported to IcedTea6. 
issue6-extra-line-closing-joint.patch removes the extra line that is 
drawn on the top left corner of the star, fixing that issue.

Each patch also includes a jtreg test for the bug.

> The second attached picture without pink markings displays how the 
> testcase looks using Sun's properitary java2d for reference.
> 
> Cheers.
> Xerxes

Cheers,
Omair

[1] http://hg.openjdk.java.net/jdk7/2d/jdk/rev/9318628e8eee
-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue5-internal-joint.patch
Type: text/x-patch
Size: 4952 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090429/ff53d732/issue5-internal-joint.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: issue6-extra-line-closing-joint.patch
Type: text/x-patch
Size: 5031 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090429/ff53d732/issue6-extra-line-closing-joint.patch