Gervill changes

Mark Wielaard mark at klomp.org
Tue Dec 1 11:12:42 PST 2009


Hi Gary,

> OpenJDK 6 and 7 have a fix that our version of Gervill doesn't have
> (http://tinyurl.com/ylm599p).  How do I go about changing that in
> icedtea6?  Can I just commit a change to the file in overlays/openjdk
> or do I need to do something else?

Just apply that patch to the files in the overlay and that takes care of
everything. (But you might want to get rid of the strange whitespace
only changes first to minimize the actual patch.)

Longer term it is better to pull from one upstream. So double check that
those changes aren't in upstream cvs from which we import:
https://gervill.dev.java.net/source/browse/gervill/
If they are, then just import a new cvs version, which makes it easier
to see if we have any changes left. If we had changes in previous
imports I made sure to post about them on the audio-engine-dev list. The
last one seems to be from some time ago, but includes the (minimal)
diffs at that point:
http://mail.openjdk.java.net/pipermail/audio-engine-dev/2008-November/000062.html

Then double check that there are no differences between the overlay
files and the files in openjdk6 (note that some files have been renamed
and that some of the files might have random indentation/whitespace
changes).

As Joe said it would be ideal if all changes merged together and the
overlay for gervill could go away. The only reason that hasn't been done
is that in the past openjdk6 didn't contain any code from gervill and
for some time it contained only older versions without some important
bug fixes (and some sources were reformatted from upstream, which made
comparison difficult). That was my plan with the last import, but I
never got to it:
http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-May/005710.html

Cheers,

Mark




More information about the distro-pkg-dev mailing list