Patch for IcedTea6 - Gervill overlay

[Andrew John Hughes]

2009/12/1 Mark Wielaard <mark at klomp.org>:
> On Tue, 2009-12-01 at 17:47 +0100, Pavel Tisnovsky wrote:
>> I synchronized Gervill sources stored in IcedTea overlay with OpenJDK
>> sources (there are some changes not included in official Gervill
>> package). I wish to thank Mark for his suggestions :-)
>>
>> JTreg results:
>> http://file.brq.redhat.com/~ptisnovs/jtreg/icedtea6/2009-12-01/
>> (all sound test passes now)
>
> Thanks for doing a full test run, and great to hear all sound related
> tests now pass. But that doesn't seem to be a publicly accessible
> machine.
>
>> Is it possible to push these changes to IcedTea6 repository?
>
> I looked over the changes quickly and they look fine to me.
> Thanks for doing this. Please do push. The changes seem to correspond
> with openjdk6/jdk changes:
>
> changeset:   160:ac4f0c58f4c7
> user:        kalli
> date:        Sat Jul 25 01:30:40 2009 +0000
> description:
> 6833357: Improve time-stamp support in Gervill to reduce jitter.
>
> changeset:   135:a42d6999734b
> user:        kalli
> date:        Fri Apr 24 22:52:33 2009 +0000
> description:
> 6823449: Gervill: ArrayIndexOutOfBoundsException thrown when trying to
> play too may voices at same time.
>
> changeset:   129:2b6b4a913149
> user:        amenkov
> date:        Wed Apr 08 13:10:49 2009 +0400
> description:
> 6806019: 38 JCK api/javax_sound/midi/ tests fails starting from jdk7 b46
>
> Could you add the above to the README file, to make sure there is a log?
>
> I saw Gary's message about the same issue first and responded to him
> also (his patch only covered one of the above changes though). Did you
> coordinate?
>
> So, with your changes, the diff between the files in the gervill overlay
> and the same files in the openjdk6 repository are now the same?
> If so, then after this is committed and fully tested to work as
> expected, the next step seems to be to finally remove the overlay from
> the build.
>
> Thanks,
>
> Mark
>
>

What 'OpenJDK sources' are we referring to here? Is this b17 or the
current Mercurial tree?

If it is b17, why are we synchronising our local copy rather than just
dropping it altogether, as both Joe and I have suggested?

Thanks,
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8