RFC: Minor patch to set JDK_UPDATE_VERSION based on drop

Deepak Bhole dbhole at redhat.com
Wed Dec 23 11:14:20 PST 2009


* Andrew John Hughes <gnu_andrew at member.fsf.org> [2009-12-22 19:37]:
> 2009/12/22 Deepak Bhole <dbhole at redhat.com>:
> > * Andrew John Hughes <gnu_andrew at member.fsf.org> [2009-12-22 15:12]:
> >> 2009/12/22 Deepak Bhole <dbhole at redhat.com>:
> >> > * Deepak Bhole <dbhole at redhat.com> [2009-12-22 14:37]:
> >> >> As discussed earlier, based on Mark's suggestion, here is a patch to set
> >> >> the JDK update version based on the drop version. I tested it with
> >> >> icedtea6 head and it seems to work correctly.
> >> >>
> >> >> ChangeLog:
> >> >> 2009-12-22  Deepak Bhole <dbhole at redhat.com>
> >> >>
> >> >>     * Makefile.am: Set JDK_UPDATE_VERSION based on upstream drop version
> >> >>
> >> >> Cheers,
> >> >> Deepak
> >> >
> >> > I think this will go better if I actually attach the patch..
> >> >
> >> > Deepak
> >> >
> >>
> >> This patch uses the version of IcedTea rather than the drop number
> >> which would be OPENJDK_VERSION.  Maybe the latter would be better as
> >> it's a whole number rather than 1.6, 1.7, etc.?
> >
> > Ah, I see the issue now. Okay, updated patch attached.
> >
> > Cheers,
> > Deepak
> >
> >> --
> >> Andrew :-)
> >>
> >> Free Java Software Engineer
> >> Red Hat, Inc. (http://www.redhat.com)
> >>
> >> Support Free Java!
> >> Contribute to GNU Classpath and the OpenJDK
> >> http://www.gnu.org/software/classpath
> >> http://openjdk.java.net
> >>
> >> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> >> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
> >
> 
> Looks good to me.

Thanks! Pushed to 6 and 7.

Cheers,
Deepak

> -- 
> Andrew :-)
> 
> Free Java Software Engineer
> Red Hat, Inc. (http://www.redhat.com)
> 
> Support Free Java!
> Contribute to GNU Classpath and the OpenJDK
> http://www.gnu.org/software/classpath
> http://openjdk.java.net
> 
> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8



More information about the distro-pkg-dev mailing list