mozilla.javascript still encumbered...?

[Lillian Angel]

Hi,

Deepak Bhole wrote:
> * Lillian Angel <langel at redhat.com> [2009-02-11 14:39]:
>   
>> Hi,
>>
>> I was attempting to build the yui-compressor tool[1], and I found that 
>> IcedTea/OpenJDK is missing some mozilla.javascript[2] classes still. At the 
>> moment, I don't have the time to start implementing these, but let me know 
>> if anyone does.
>>
>> The tool does build with JDK 1.6.0.
>>
>> https://bugzilla.redhat.com/show_bug.cgi?id=485135
>>
>> Cheers,
>> Lillian
>>
>>
>>     
>
> Looks like we need to upgrade rhino. 1.7R1 appears to have the new
> stuff. Just did a quick search for a couple of things:
>
> $ grep -rE "isStrictMode|reportWarningAsError|DUPLICATE_CONST" rhino1_7R1/src/ | awk '{print $1}' | sort -u
> rhino1_7R1/src/org/mozilla/javascript/CompilerEnvirons.java:
> rhino1_7R1/src/org/mozilla/javascript/Parser.java:
>   

Great! Thanks for looking into this so quickly. I requested the Fedora 
maintainer upgrade to 1.7 (or orphan it, so I can pick it up). We can 
upgrade the dependency in IcedTea/6.


Cheers,
Lillian

> Deepak
>
>   
>> [1]
>> http://www.julienlecomte.net/yuicompressor/
>>
>> [2]
>> [...yuicompressor-2.4.2]$ ant
>> Buildfile: build.xml
>>
>> -load.properties:
>>
>> -init:
>>    [mkdir] Created dir: /home/langel/yuicompressor-2.4.2/build
>>
>> build.classes:
>>    [mkdir] Created dir: /home/langel/yuicompressor-2.4.2/build/classes
>>    [javac] Compiling 12 source files to 
>> /home/langel/yuicompressor-2.4.2/build/classes
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:120: 
>> cannot find symbol
>>    [javac] symbol  : method isStrictMode()
>>    [javac] location: class org.mozilla.javascript.CompilerEnvirons
>>    [javac]         if (compilerEnv.isStrictMode())
>>    [javac]                        ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:127: 
>> cannot find symbol
>>    [javac] symbol  : method reportWarningAsError()
>>    [javac] location: class org.mozilla.javascript.CompilerEnvirons
>>    [javac]         if (compilerEnv.reportWarningAsError()) {
>>    [javac]                        ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:568: 
>> cannot find symbol
>>    [javac] symbol  : method isStrictMode()
>>    [javac] location: class org.mozilla.javascript.CompilerEnvirons
>>    [javac]             if (compilerEnv.isStrictMode() && 
>> !body.hasConsistentReturnUsage())
>>    [javac]                            ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:568: 
>> cannot find symbol
>>    [javac] symbol  : method hasConsistentReturnUsage()
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]             if (compilerEnv.isStrictMode() && 
>> !body.hasConsistentReturnUsage())
>>    [javac]                                                    ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:639: 
>> cannot find symbol
>>    [javac] symbol  : variable PARENTHESIZED_PROP
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]         if (pn.getProp(Node.PARENTHESIZED_PROP) == null &&
>>    [javac]                            ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:676: 
>> cannot find symbol
>>    [javac] symbol  : method isStrictMode()
>>    [javac] location: class org.mozilla.javascript.CompilerEnvirons
>>    [javac]                 if (compilerEnv.isStrictMode() && 
>> !pn.hasSideEffects())
>>    [javac]                                ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:676: 
>> cannot find symbol
>>    [javac] symbol  : method hasSideEffects()
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]                 if (compilerEnv.isStrictMode() && 
>> !pn.hasSideEffects())
>>    [javac]                                                      ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1107: 
>> cannot find symbol
>>    [javac] symbol  : variable END_RETURNS_VALUE
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]                 if (functionEndFlags == Node.END_RETURNS_VALUE)
>>    [javac]                                             ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1110: 
>> cannot find symbol
>>    [javac] symbol  : variable END_RETURNS
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]                 functionEndFlags |= Node.END_RETURNS;
>>    [javac]                                         ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1112: 
>> cannot find symbol
>>    [javac] symbol  : variable END_RETURNS
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]                 if (functionEndFlags == Node.END_RETURNS)
>>    [javac]                                             ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1115: 
>> cannot find symbol
>>    [javac] symbol  : variable END_RETURNS_VALUE
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]                 functionEndFlags |= Node.END_RETURNS_VALUE;
>>    [javac]                                         ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1269: 
>> createVariables(int) in org.mozilla.javascript.IRFactory cannot be applied 
>> to (int,int)
>>    [javac]             pn = nf.createVariables(Token.CONST, 
>> ts.getLineno());
>>    [javac]                    ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1272: 
>> createVariables(int) in org.mozilla.javascript.IRFactory cannot be applied 
>> to (int,int)
>>    [javac]             pn = nf.createVariables(Token.VAR, ts.getLineno());
>>    [javac]                    ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1289: 
>> cannot find symbol
>>    [javac] symbol  : method addConst(java.lang.String)
>>    [javac] location: class org.mozilla.javascript.ScriptOrFnNode
>>    [javac]                 if (!currentScriptOrFn.addConst(s)) {
>>    [javac]                                       ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1293: 
>> 'void' type not allowed here
>>    [javac]                     if (currentScriptOrFn.addVar(s) != 
>> ScriptOrFnNode.DUPLICATE_CONST)
>>    [javac]                                                 ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1293: 
>> cannot find symbol
>>    [javac] symbol  : variable DUPLICATE_CONST
>>    [javac] location: class org.mozilla.javascript.ScriptOrFnNode
>>    [javac]                     if (currentScriptOrFn.addVar(s) != 
>> ScriptOrFnNode.DUPLICATE_CONST)
>>    [javac]                                                                  
>>     ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1299: 
>> incompatible types
>>    [javac] found   : void
>>    [javac] required: int
>>    [javac]                 int dupState = currentScriptOrFn.addVar(s);
>>    [javac]                                                        ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1300: 
>> cannot find symbol
>>    [javac] symbol  : variable DUPLICATE_CONST
>>    [javac] location: class org.mozilla.javascript.ScriptOrFnNode
>>    [javac]                 if (dupState == ScriptOrFnNode.DUPLICATE_CONST)
>>    [javac]                                               ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1302: 
>> cannot find symbol
>>    [javac] symbol  : variable DUPLICATE_PARAMETER
>>    [javac] location: class org.mozilla.javascript.ScriptOrFnNode
>>    [javac]                 else if (dupState == 
>> ScriptOrFnNode.DUPLICATE_PARAMETER)
>>    [javac]                                                    ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1304: 
>> cannot find symbol
>>    [javac] symbol  : variable DUPLICATE_VAR
>>    [javac] location: class org.mozilla.javascript.ScriptOrFnNode
>>    [javac]                 else if (dupState == 
>> ScriptOrFnNode.DUPLICATE_VAR)
>>    [javac]                                                    ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1330: 
>> cannot find symbol
>>    [javac] symbol  : method isStrictMode()
>>    [javac] location: class org.mozilla.javascript.CompilerEnvirons
>>    [javac]             if (compilerEnv.isStrictMode() && 
>> !pn.hasSideEffects())
>>    [javac]                            ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:1330: 
>> cannot find symbol
>>    [javac] symbol  : method hasSideEffects()
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]             if (compilerEnv.isStrictMode() && 
>> !pn.hasSideEffects())
>>    [javac]                                                  ^
>>    [javac] 
>> /home/langel/yuicompressor-2.4.2/src/org/mozilla/javascript/Parser.java:2065: 
>> cannot find symbol
>>    [javac] symbol  : variable PARENTHESIZED_PROP
>>    [javac] location: class org.mozilla.javascript.Node
>>    [javac]             pn.putProp(Node.PARENTHESIZED_PROP, Boolean.TRUE);
>>    [javac]                            ^
>>    [javac] 23 errors
>>
>> BUILD FAILED
>> /home/langel/yuicompressor-2.4.2/build.xml:23: Compile failed; see the 
>> compiler error output for details.
>>
>> Total time: 2 seconds
>>
>>