changeset in /hg/icedtea6: Backport newly Freed tests.

Joseph D. Darcy Joe.Darcy at Sun.COM
Fri Feb 13 12:49:16 PST 2009


Andrew John Hughes wrote:
> 2009/2/13 Joseph D. Darcy <Joe.Darcy at sun.com>:
>   
>> Hello.
>>
>> The annotations test patch is unnecessary.
>>
>> The tests in question that in JDK 7 live in
>>   test/java/lang/annotation (singular)
>> have since build 13 lived in OpenJDK 6 at
>>   test/java/lang/annotations (plural)
>>
>> See
>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/file/f6b99ef3deee/test/java/lang/annotations/
>>
>> The original closed tests lived in an "annotations" directory, but by the
>> naming conventions for tests they should have been in "annotation" so I put
>> the JDK 7 tests in the latter directory when I opened them up for that
>> release.
>>
>>     
>
> Ok, this wasn't mentioned in the commit or anywhere else.

Why would it be?

>   Can you fix
> the naming in OpenJDK6 to match?
>   

I do not plan to move the existing OpenJDK 6 tests.

>> Especially since there is a public OpenJDK 6 Mercurial forest now, in the
>> future when there is interest in having a Sun patch ported to IcedTea 6, I
>> suggest contacting us at Sun about getting the change in the upstream
>> OpenJDK 6 master directly.
>>
>>     
>
> I expect these tests will be in the next build drop.  The point of
> backporting them was so we could start running them in the meantime.
>
>   

If the goal is having more tests (or other changes) in the upstream 
OpenJDK 6 repository there are two general paths:

1) Apply patch to IcedTea6
2) Changes later get added to OpenJDK 6 directly
3) Remove newly unnecessary patch from IcedTea6

or

1) Change OpenJDK 6 directly


If it happens promptly, the second path strikes me as more efficient all 
around :-)

-Joe



More information about the distro-pkg-dev mailing list