Patch proposal to fix PluginAppletViewer signed applets initialization failure bug due to timeouts from user interaction.

[Deepak Bhole]

* Xerxes Rånby <xerxes at zafena.se> [2009-02-17 10:48]:
> This is a proposal for a patch to icedtea6 PluginAppletViewer to make the 
> applet initialization work in cases when a user has to manually grant a 
> signed application to run, this can take indefinately long times. This 
> initialization timeout bug also break initialization on platforms with slow 
> startuptimes like ARM using Zero Hotspot.
>
> The current implementation of the PluginAppletViewer only gives the 
> NetxPanel 10 seconds to initialize the applet. This initialization fails 
> ofcourse when Netx displays the security warning popup asking for user 
> action unless the user responds within 10 seconds.
>
> One way i could think of improving this patch further is to only allow the 
> plugin to wait for the applet during APPLET_LOADING state of the 
> AppletPanel.
> A way to archive this further improvement is to make the PluginAppletViewer 
> an AppletListener and register it to listen for the APPLET_LOADING and 
> APPLET_LOADING_COMPLETED events.
>
> Suggestions are welcome.
>
> Cheers and have a great day!
> Xerxes
>
>
>

Patch has been applied with my latest commit. Thank you very much!

Deepak

>
>
>
>
>

> diff -r 551c49cb2e2a plugin/icedtea/sun/applet/PluginAppletViewer.java
> --- a/plugin/icedtea/sun/applet/PluginAppletViewer.java	Wed Feb 11 11:49:45 2009 -0500
> +++ b/plugin/icedtea/sun/applet/PluginAppletViewer.java	Tue Feb 17 14:50:37 2009 +0100
> @@ -302,15 +302,12 @@
>      showStatus(amh.getMessage("status.start"));
>   	initEventQueue();
>   	
> -    // Wait for a maximum of 10 seconds for the panel to initialize
> +    // Wait for the panel to initialize
>      // (happens in a separate thread)
>   	Applet a;
> -    int maxSleepTime = 10000;
> -    int sleepTime = 0;
> -    while ((a = panel.getApplet()) == null && sleepTime < maxSleepTime) {
> +    while ((a = panel.getApplet()) == null && panel.getAppletHandlerThread().isAlive()) {
>     	 try {
>     		 Thread.sleep(100);
> -   		 sleepTime += 100;
>     		 PluginDebug.debug("Waiting for applet to initialize... ");
>     	 } catch (InterruptedException ie) {
>     		 ie.printStackTrace();
> @@ -480,20 +477,23 @@
>               // object should belong to?
>               Object o;
>  
> -             // Wait for a maximum of 10 seconds for the panel to initialize
> +             // Wait for the panel to initialize
>               // (happens in a separate thread)
> -             int maxSleepTime = 10000;
> -             int sleepTime = 0;
> -             while ((o = panel.getApplet()) == null && sleepTime < maxSleepTime) {
> +             while ((o = panel.getApplet()) == null && panel.getAppletHandlerThread().isAlive()) {
>              	 try {
>              		 Thread.sleep(100);
> -            		 sleepTime += 100;
>              		 PluginDebug.debug("Waiting for applet to initialize...");
>              	 } catch (InterruptedException ie) {
>              		 ie.printStackTrace();
>              	 }
>               }
>  
> +             // Still null?
> +             if (panel.getApplet() == null) {
> +               this.streamhandler.write("instance " + identifier + " reference " + -1 + " fatalError " + "GetJavaObject Initialization failed");
> +               return;
> +             }
> +
>               PluginDebug.debug ("Looking for object " + o + " panel is " + panel);
>               AppletSecurityContextManager.getSecurityContext(0).store(o);
>               PluginDebug.debug ("WRITING 1: " + "context 0 reference " + reference + " GetJavaObject "