changeset in /hg/icedtea6: 2009-01-08 Matthias Klose <doko at ubu...

[Andrew Haley]

Matthias Klose wrote:
> Andrew Haley schrieb:
>> Matthias Klose wrote:
>>> Andrew Haley schrieb:
>>>> doko at ubuntu.com wrote:
>>>>> changeset 48a808c06395 in /hg/icedtea6
>>>>> details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=48a808c06395
>>>>> description:
>>>>> 	2009-01-08  Matthias Klose  <doko at ubuntu.com>
>>>>>
>>>>> 	        * patches/hotspot/14.0b08/icedtea-no-precompiled.patch: Don't use
>>>>> 	        precompiled header files in hotspot.
>>>>> 	        * HACKING: Document the above.
>>>> Has there been any discussion about this?  I can't remember seeing
>>>> any.  This is a regression for those of us working on HotSpot.
>>> No, the patch is not applied, just checked in for convenience. Does this require
>>> discussion?
>> In general, changes should be discussed.
>>
>> As this one is not applied I suppose it's not a substantive change.
>> However, I would really like to know what problem it's supposed to
>> solve.
> 
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2009-January/004396.html
> did show the need to build without precompiled headers. instead of having
> everybody to figure out how to do this, I checked in the patch. Sure this could
> be moved to a patches/contrib or patches/unused directory as well.

Ah, OK, it's just a workaround for a compiler bug.

I'm not wildly keen on putting patches in contrib, for what it's worth.
If it's useful to you it'll probably be useful to others too.

Please don't confuse my request for this patch to be explained with
a request for it to be removed.

Andrew.