RFC: Minor build correctness patch
Lillian Angel
langel at redhat.com
Tue Jul 7 08:04:29 PDT 2009
jon.vanalten at redhat.com wrote:
> Hi,
>
> The attached patch corrects a minor issue noted in http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=289
>
> Include statements for the .c files affected are missing, resulting in compiler warnings. While this wasn't affecting the build or correct performance, it is good practice to include headers where appropriate. This patch, adapted from that provided by the original bug reporter above, adds the include statements.
>
> Comments welcome.
As per Andrew Hughes comments in the bug, I would like to see this filed
upstream to Sun. I have CC'ed Matthew Flaschen.
For now, it is fine to commit.
Cheers,
Lillian
More information about the distro-pkg-dev
mailing list