RFC: Rewrite of cookie support in plugin

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2009-07-07 15:48]:
> Hi,
>
> Deepak Bhole wrote:
>> Oops. Original message is missing 2 new files from the patch. Sorry
>> about that. New patch attached.
>>
>> Deepak
>>
>> * Deepak Bhole <dbhole at redhat.com> [2009-07-03 17:48]:
>>> This patch rewrites cookie support in the plugin. The old way was
>>> static, set at initialization time. Additionally, it did not support
>>> cookie provision for connection requests made by the applet internally.
>>>
>>> This patch fixes all of that. Cookie information is now supplied to Java
>>> in real-time from Mozilla side, as it should be.
>>>
>>> Thanks to Omair for the initial error trace.
>>>
>>> This patch fixes rhbz 506730:
>>> https://bugzilla.redhat.com/show_bug.cgi?id=506730
>>>
>>> http://www.sbm.no/ will now load correctly with this patch.
>>>
>>> ChangeLog:
>>>     * IcedTeaPlugin.cc: Add suppport for cookie info requests from applets.
>>>     * plugin/icedtea/sun/applet/PluginAppletViewer.java: Rework cookie support
>>>     to make it dynamic.
>>>     * plugin/icedtea/sun/applet/PluginMain.java: Wire in custom cookie store
>>>     that dynamically requests cookie information from C++ side.
>>>     * rt/net/sourceforge/jnlp/JNLPFile.java: Remove old cookie handling code.
>>>     * rt/net/sourceforge/jnlp/Launcher.java: Same.
>>>     * rt/net/sourceforge/jnlp/NetxPanel.java: Same.
>>>     * rt/net/sourceforge/jnlp/PluginBridge.java: Same.
>>>     * rt/net/sourceforge/jnlp/cache/CacheUtil.java: Same.
>>>     * rt/net/sourceforge/jnlp/cache/Resource.java: Same.
>>>     * rt/net/sourceforge/jnlp/cache/ResourceTracker.java: Same.
>>>     * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java: Same.
>>>
>>> Comments?
>>>
>>> Deepak
>>
>
> I am assuming that aside from the classes that manage cookies, nothing  
> should be storing or passing them around. However, there are still many  
> references to cookies. For example,net.sourceforge.jnlp.ExtensionDesc  
> contains:
> public ExtensionDesc(String name, Version version, URL location, String  
> cookieStr)
>
> Please remove all unused references to cookies.
>

Good catch! New patch attached.

Cheers,
Deepak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ITP-cookie-support-rewrite2.patch
Type: text/x-patch
Size: 33277 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090707/08114f1d/ITP-cookie-support-rewrite2.patch