integrating the arm bytecode interpreter into IcedTea

[Gary Benson]

Matthias Klose wrote:
> +#if defined(PRODUCT) && defined(HOTSPOT_ASM)

So my first question is why is everything conditionalized on PRODUCT?
Not being able to build not-PRODUCT means no assertions, no debug
helpers and no diagnostic options.  I'd like to see all these
conditionals replaced with "#ifdef HOTSPOT_ASM".

> +#endif

HotSpot seems to follow the convention that #endifs are annotated:

  #ifdef HOTSPOT_ASM
  ...
  #endif // HOTSPOT_ASM

> diff -r 914f2022b402 ports/hotspot/build/linux/makefiles/zero.make
...
+ifdef ICEDTEA_ZERO_BUILD
+ifeq ($(ZERO_LIBARCH),arm)
+Obj_Files += cppInterpreter_arm.o
+CFLAGS += -DHOTSPOT_ASM -DHW_NULL_PTR_CHECK -g0 -O2
+%.o: %.S
+     @echo Assembling $<
+     $(QUIETLY) $(REMOVE_TARGET)
+     $(COMPILE.CC) -o $@ $< $(COMPILE_DONE)
+endif
+endif

The "ifdef ICEDTEA_ZERO_BUILD" is unnecessary here as this makefile is
only used for Zero builds.

> diff -r 914f2022b402 ports/hotspot/src/cpu/zero/vm/bytecodes_zero.cpp
...
> @@ -29,4 +29,32 @@
>  void Bytecodes::pd_initialize()
>   {
>      // No zero specific initialization
>      +#if defined(PRODUCT) && defined(HOTSPOT_ASM)
     
The "// No zero specific initialization" line needs removing, as there
is now some zero specific initialization.

> diff -r 914f2022b402 ports/hotspot/src/cpu/zero/vm/mkbc.c

This file isn't part of HotSpot, it's a generator for some other files.
Can it be placed into contrib?

Cheers,
Gary

--
http://gbenson.net/