RFC: Netx - Support VM arguments specified in the JNLP file
Deepak Bhole
dbhole at redhat.com
Wed Jun 3 11:07:52 PDT 2009
* Omair Majid <omajid at redhat.com> [2009-06-03 13:41]:
Looks good. Couple of things though:
1. getForksAlowed() is spelled incorrectly..
2. There is a lot of unnecessary wrapping/unwrapping going on with the
whole convert array to list, add to list, convert list to array and
iterate over array. Why not just change initialArgs to be a list, and
then just use that list everywhere and iterate over it when launching the
new vm?
Cheers,
Deepak
-------------- next part --------------
A non-text attachment was scrubbed...
Name: netx-jvm-args.patch
Type: text/x-patch
Size: 11903 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090603/9c6634d9/netx-jvm-args.patch
More information about the distro-pkg-dev
mailing list