RFC: Netx - Refactor paths
Deepak Bhole
dbhole at redhat.com
Wed Jun 17 11:12:17 PDT 2009
* Omair Majid <omajid at redhat.com> [2009-06-16 15:50]:
> Hi,
>
> This patch consolidates file paths spread throughout netx code into
> JNLPRuntime.java.
>
> ChangeLog:
> 2009-06-16 Omair Majid <omajid at redhat.com>
>
> * rt/net/sourceforge/jnlp/runtime/Boot.java:
> Remove aboutFile.
> (getAboutFile): Get path from JNLPRuntime.
> (getBaseDir): Fix comments.
> * rt/net/sourceforge/jnlp/runtime/JNLPRuntime.java
> Add HOME_DIR, NETXRC_FILE, NETX_DIR, SECURITY_DIR,
> CERTIFICATES_FILE, LOCKS_DIR, and NETX_ABOUT_FILE.
> (getDefaultBaseDir): Remove calls to loadWindowIcon and isHeadless()
> because they are unused. Use HOME_DIR and NETX_DIR.
> (getProperties): Use NETXRC_FILE instead of hardcoded file name.
> * rt/net/sourceforge/jnlp/security/SecurityUtil.java
> Remove homeDir, certDir and certFile.
> (getTrustedCertsFilename): Use HOME_DIR and CERTIFICATES_FILE.
> (checkTrustedCertsFile): Find parent directory from certFile.
>
> Any comments?
>
Looks good. Assuming you have tested this, go ahead and apply.
Deepak
> Cheers,
> Omair
More information about the distro-pkg-dev
mailing list