RFC: Netx - Implement SingeInstanceService

Omair Majid omajid at redhat.com
Wed Jun 24 12:07:00 PDT 2009


Deepak Bhole wrote:
> * Omair Majid <omajid at redhat.com> [2009-06-24 14:23]:
>> Deepak Bhole wrote:
>>> * Omair Majid <omajid at redhat.com> [2009-06-23 10:28]:
>>>> Hi,
>>>>
>>>> Updated patch attached.
>>>>
>>> One very minor nitpick:
>>>
>>> In SingleInstanceLock::getPort(), if an exception occurs, port is set 
>>> to Integer.MIN_VALUE. It should probably be set to INVALID_PORT, since 
>>> such a variable has already been defined and is used in comparison 
>>> elsewhere.
>>>
>>> Other than that, looks good to me!
>> Fixed. Ok to commit?
>>
> 
> Yep!
> 
Thanks. Committed as changeset ed75376cfe3a.

Cheers,
Omair



More information about the distro-pkg-dev mailing list