Possible bug in NIO2 patches
Andrew John Hughes
gnu_andrew at member.fsf.org
Tue Mar 10 01:49:36 PDT 2009
2009/3/10 Michael Franz <mvfranz at gmail.com>:
> Hi,
>
> while investigating the nio2 patches I noticed that there is a mistake (I
> think) in the patches to nio/Makefile. There are new java classes added to
> a section but the continuation character was not added. Below is the
> correction.
>
> Michael
>
> --- icedtea-nio2.patch.orig 2009-03-09 23:01:28.000000000 -0400
> +++ icedtea-nio2.patch 2009-03-09 23:03:19.000000000 -0400
> @@ -321,7 +321,7 @@
> + sun/nio/ch/WindowsAsynchronousFileChannelImpl.java \
> + sun/nio/ch/WindowsAsynchronousServerSocketChannelImpl.java \
> + sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java \
> - sun/nio/ch/WindowsSelectorImpl.java
> + sun/nio/ch/WindowsSelectorImpl.java \
> + sun/nio/fs/WindowsNativeDispatcher.java \
> + sun/nio/fs/RegistryFileTypeDetector.java
> endif # PLATFORM = windows
>
>
Well spotted; unsurprisingly the Windows build hasn't been tested... ;)
Most of this patch is gone now in my local copy with the move to b50.
I'll push this once it builds.
--
Andrew :-)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev
mailing list