The old Metal-Swing bug

[theUser BL]

Hi all!

I have for years also saif it in the Forum of java.net and on the classpath-Mailinglist (they have for example reimplemented the bug, to look like the original Java).

There are bugs in Metal JScrollBar, when it stands alone. This bug exists since the beginning of Swing, where it was a seperate package for Java 1.1.
With the Metal Steel-Skin it is much more  apparent then with the Metal Ocean-Skin. But in both cases the bugs exists.

At first look at Horizontal JScrollBar of the JFileChooser
http://img17.imageshack.us/my.php?image=jfilechooser.png
There is no bug. This Scroobar is perfect drawn.
Now have a look at JScrollBars placed in an Window
http://img5.imageshack.us/my.php?image=beforeq.png

Differ the horizontal Scrollbar with this of the JFileChooser. You will see, that there are some bugs in it. The most obviously bug is the wrog shadow under the Scrollbar.
I have tried to eleminate it with two possibilities (where comments with "my bugfix" begins, I have something changed):
In javax.swing.plaf.metal.MetalScrollBarUI.java


-----------------------------------------------------
else  // HORIZONTAL
{
    if ( !isFreeStanding ) {
        trackBounds.height += 2;
    }

    if ( c.isEnabled() ) {
        g.setColor( darkShadowColor );
    g.drawLine( 0, 0, trackBounds.width - 1, 0 );  // top
    g.drawLine( 0, 2, 0, trackBounds.height - 2 ); // left
    g.drawLine( 0, trackBounds.height - 2, trackBounds.width - 1, trackBounds.height - 2 ); // bottom
    g.drawLine( trackBounds.width - 1, 2, trackBounds.width - 1, trackBounds.height - 1 ); // right

    g.setColor( shadowColor );
    //    g.setColor( Color.red);
    g.drawLine( 1, 1, trackBounds.width - 2, 1 );  // top
    g.drawLine( 1, 1, 1, trackBounds.height - 3 ); // left
    g.setColor( highlightColor );  // my bugfix: this added
    g.drawLine( 0, trackBounds.height - 1, trackBounds.width - 1, trackBounds.height - 1 ); // bottom
        g.setColor( shadowColor ); // my bugfix: this added
    if (scrollbar.getValue() != scrollbar.getMaximum()) {  // thumb shadow
        int x = thumbRect.x + thumbRect.width - trackBounds.x;
//        g.drawLine( x, 1, x, trackBounds.height-1);
          g.drawLine( x, 1, x, trackBounds.height-2);  // my bugfix: this instead the out commented
    }
    } else {
        MetalUtils.drawDisabledBorder(g, 0, 0, trackBounds.width, trackBounds.height );
    }

    if ( !isFreeStanding ) {
        trackBounds.height -= 2;
    }
}

-----------------------------------------------------

and a second solution I have


-----------------------------------------------------
 else  // HORIZONTAL
{
    if ( !isFreeStanding ) {
        trackBounds.height += 2;
    }

    if ( c.isEnabled() ) {
        g.setColor( darkShadowColor );
    g.drawLine( 0, 0, trackBounds.width - 1, 0 );  // top
    g.drawLine( 0, 2, 0, trackBounds.height - 2 ); // left
    g.drawLine( 0, trackBounds.height - 2, trackBounds.width - 1, trackBounds.height - 2 ); // bottom
    g.drawLine( trackBounds.width - 1, 2, trackBounds.width - 1, trackBounds.height - 1 ); // right

    g.setColor( shadowColor );
    //    g.setColor( Color.red);
    g.drawLine( 1, 1, trackBounds.width - 2, 1 );  // top
    g.drawLine( 1, 1, 1, trackBounds.height - 3 ); // left
    // g.drawLine( 0, trackBounds.height - 1, trackBounds.width - 1, trackBounds.height - 1 ); // bottom  // my bugfix: here out commented and insert later
    if (scrollbar.getValue() != scrollbar.getMaximum()) {  // thumb shadow
        int x = thumbRect.x + thumbRect.width - trackBounds.x;
        g.drawLine( x, 1, x, trackBounds.height-1);
    }
    g.setColor( highlightColor );  // my bugfix: this added
        g.drawLine( 0, trackBounds.height - 1, trackBounds.width - 1, trackBounds.height - 1 ); // bottom // my bugfix: Now here integrated
        g.setColor( shadowColor ); // my bugfix: this added
    } else {
        MetalUtils.drawDisabledBorder(g, 0, 0, trackBounds.width, trackBounds.height );
    }

    if ( !isFreeStanding ) {
        trackBounds.height -= 2;
    }
}
-----------------------------------------------------

After that it looks like
http://img19.imageshack.us/my.php?image=afterq.png

It is still not completly correct. As you can see, the one vertical lice of the horizontal scrollbar goes to far.
It would help to write intead
g.drawLine( x, 1, x, trackBounds.height-1);
an
g.drawLine( x, 1, x, trackBounds.height-3);

But in this case the Vertical ScrollBar have the same bug and there it must also be fixed.

Hope that this bug will be in any time eleminated from Java. As I said, it exists since the first Swing-version!

Greatings
theuserbl


_________________________________________________________________
http://redirect.gimas.net/?n=M0903xIMTicTacToe
Kostenlose Spannung? Spiel jetzt mit Freunden TIC TAC TOE in 3D!