[RFC] Remove outdated postscript test from icedtea6

Omair Majid omajid at redhat.com
Fri Mar 13 09:11:08 PDT 2009


Andrew John Hughes wrote:
> 2009/3/12 Omair Majid <omajid at redhat.com>:
>> Hi,
>>
>> This patch removes the javax/print/attribute/PSCopiesFlavorTest.java jtreg
>> (jdk) test from IcedTea6. The test was written for a CUPS/postscript bug[1].
>>
>> There are several issues with this test. It cant handle the case where there
>> is no default printer; it throws a NullPointerException without actually
>> testing what it's supposed to. The bug that this test checks for has become
>> obsolete. The issue was that when a postscript file specified the number of
>> copies, and the user asked for a certain number of copies, the number of
>> copies in the postscript file would generally take precedence. This meant
>> that from a user's point of view, there was no way to set the number of
>> copies. This is no longer true for modern version of CUPS. The JRE has
>> already been fixed so that it returns Copies as a valid attribute for
>> postscript documents, making this test incorrect.
>>
>> Cheers
>> Omair
>>
>> [1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6527316
>>
> 
> You should file an OpenJDK bug for this patch as well:
> 
> https://bugs.openjdk.java.net/

Done: https://bugs.openjdk.java.net/show_bug.cgi?id=100022
> 
> I can see the logic, but for the time being it might be better to just
> exclude it from the JTReg tests in IcedTea and wait for feedback from
> Sun on complete removal.

Done: http://icedtea.classpath.org/hg/icedtea6/rev/36bef6593176

Thanks,
Omair



More information about the distro-pkg-dev mailing list