RFC: add --enable-experimental-openjdk-cross-compilation option

Robert Schuster thebohemian at gmx.net
Wed May 13 08:49:43 PDT 2009


Hi Andrew,

Andrew John Hughes schrieb:
>>> I'd still prefer that the option's name more clearly related to its
>>> purpose, as we discussed before,
>> I think the name is what it does. It enables openjdk's cross-compilation
>> support. At the moment this consists only of disabling the sanity checks
>> but the next patch will handle calling 'uname -m' in certain places. As
>> such I argue --disable-cc-incompatible-sanity-checks is not a good
>> option (except you want 3 options related to cross-compilation in the end).
>>
> 
> Three options that are rarely used but have a clear meaning over one mega-option
> where you have to look up what it actually does is preferable IMO.
> Plus, as you say below, those who are cross-compiling will get the
> option turned on by default anyway.
I am not convinced that having 3 options is a good idea. It isn't also
about a mega-option with ununderstandable effects. On the Automake-level
it only selects a bunch of patches (3, maybe more). On the Makefile
level those patches do different stuff. That is true, but the separation
is done to make it easier to merge the changes back into OpenJDK at a
later point.

Making three options out of one adds a lot of boilerplate code to the
main Makefile.am and then. All the options need to enable together to
make sense. Enabling only one of them is not quite usefull.

Regards
Robert

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 260 bytes
Desc: OpenPGP digital signature
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090513/9125f47e/signature.asc 


More information about the distro-pkg-dev mailing list