RFC: Add support for 'java' tag and it's attributes in NetX

Deepak Bhole dbhole at redhat.com
Thu May 14 08:56:55 PDT 2009


* Omair Majid <omajid at redhat.com> [2009-05-13 16:05]:
> Hi,
>
> JNLP 6 allows using the 'java' element inside a jnlp file instead of  
> 'j2se'. This patch allows NetX to treat the 'java' element as if it were  
>  a 'j2se' element. AFAIK, NetX doesnt do anything with this yet. This  
> patch also makes NetX read and parse the 'java-vm-args' attribute of the  
>  java/j2se tag. Just like 'initial-heap-size' and 'max-heap-size', this  
> is not used anywhere by NetX.
>
> ChangeLog:
> 2009-05-13  Omair Majid  <omajid at redhat.com>
>
>     * rt/net/sourceforge/jnlp/JNLPFile.java (parse): Fix comment to
>     reflect that the element can be either 'java' or 'j2se'.
>     * rt/net/sourceforge/jnlp/JREDesc.java: Fix comment to reflect a
>     'java' element. New private variable vmArgs to keep track of
>     'java-vm-args'.
>     (JREDesc): Modify to take in an additional parameter vmArgs and
>     store it in vmArgs.
>     (getVMArgs): New function. Return the value of 'java-vm-args'
>     attribute.
>     * rt/net/sourceforge/jnlp/Parser.java: Fix comments to reflect
>     either a 'java' or 'j2se' element.
>     (getResourceDesc): Treat 'java' element identically to 'j2se'
>     element.
>     (getJRE): Read in the value of the 'java-vm-args' attribute.
>
> Any comments?
>


Oops.. just noticed I hit reply instead of reply all this morning when I
replied to this. Resending:

Looks good. Go ahead and apply. While you are looking into that area of
the code, can you also look at how to implement use of those arguments
(not urgent)?

Cheers,
Deepak



More information about the distro-pkg-dev mailing list