[RFC]: Minor plugin fix
Deepak Bhole
dbhole at redhat.com
Wed May 20 13:14:24 PDT 2009
* Lillian Angel <langel at redhat.com> [2009-05-20 16:00]:
> Hi Deepak,
>
> This patch fixes this bug:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=501391
>
> Lillian Angel <langel at redhat.com>
>
> * rt/net/sourceforge/jnlp/tools/JarSigner.java: Move creation of certs
> outside of loop, so it is not reset during each iteration.
>
>
> diff -r e810f0b2a98b rt/net/sourceforge/jnlp/tools/JarSigner.java
> --- a/rt/net/sourceforge/jnlp/tools/JarSigner.java Tue May 19
> 16:23:15 2009 +0200
> +++ b/rt/net/sourceforge/jnlp/tools/JarSigner.java Wed May 20
> 15:57:53 2009 -0400
> @@ -199,12 +199,12 @@
> public void verifyJars(List<JARDesc> jars, ResourceTracker tracker)
> throws Exception {
>
> + certs = new ArrayList<CertPath>();
> for (int i = 0; i < jars.size(); i++) {
>
> JARDesc jar = (JARDesc) jars.get(i);
> verifiedJars = new ArrayList<String>();
> unverifiedJars = new ArrayList<String>();
> - certs = new ArrayList<CertPath>();
>
> try {
>
Indentation looks a bit off ("certs ..." should start at the same column
as the "for ..."). Other than that, looks good. After fixing above,
please go ahead and commit.
Cheers,
Deepak
More information about the distro-pkg-dev
mailing list