[PATCH] Add bci to Shark frames in crash dumps

[Gary Benson]

Hi all,

My last commit makes Zero's stack printer decode Shark frames'
bcis in crash dumps.  A typical frame looks like this:

  0x7f88370d27b8: local[2]              = 0x00007f8846074df8
  0x7f88370d27c0: local[1]              = 0x00007f8842e4bb70
  0x7f88370d27c8: local[0]              = 0x00007f8846074ba0
  0x7f88370d27d0: monitor[0]->_lock     = 0x0000000000000001
  0x7f88370d27d8: monitor[0]->_obj      = 0x00007f8846074c00
  0x7f88370d27e0: oop_tmp               = 0x00007f88370d2768
  0x7f88370d27e8: method                = java.awt.EventDispatchThread.pumpOneEventForFilters(I)Z
  0x7f88370d27f0: unextended_sp         = 0x00007f88370d27a8
  0x7f88370d27f8: pc                    = 0x00007f887078401b (bci 186)
  0x7f88370d2800: frame_type            = SHARK_FRAME
  0x7f88370d2808: next_frame            = 0x00007f88370d28e0

Pretty useful huh?

Cheers,
Gary

-- 
http://gbenson.net/
-------------- next part --------------
diff -r 12f2a25cb831 -r f0c97fcc519f ChangeLog
--- a/ChangeLog	Thu May 21 14:26:47 2009 +0100
+++ b/ChangeLog	Fri May 22 14:56:54 2009 +0100
@@ -1,3 +1,11 @@
+2009-05-22  Gary Benson  <gbenson at redhat.com>
+
+	* patches/icedtea-zero.patch
+	(vmError.cpp): Don't include interpreterRuntime.hpp here.
+	* ports/hotspot/src/cpu/zero/vm/stackPrinter_zero.hpp
+	Include interpreterRuntime.hpp and scopeDesc.hpp.
+	(ZeroStackPrinter::print_word): Decode pc to get bci.
+
 2009-05-21  Gary Benson  <gbenson at redhat.com>
 
 	* ports/hotspot/src/share/vm/shark/sharkCompiler.cpp:
diff -r 12f2a25cb831 -r f0c97fcc519f patches/icedtea-zero.patch
--- a/patches/icedtea-zero.patch	Thu May 21 14:26:47 2009 +0100
+++ b/patches/icedtea-zero.patch	Fri May 22 14:56:54 2009 +0100
@@ -162,14 +162,13 @@
  
 --- openjdk/hotspot/src/share/vm/utilities/vmError.cpp.orig	2008-07-27 08:37:02.000000000 +0000
 +++ openjdk/hotspot/src/share/vm/utilities/vmError.cpp	2008-07-27 08:38:13.000000000 +0000
-@@ -25,6 +25,11 @@
+@@ -25,6 +25,10 @@
  # include "incls/_precompiled.incl"
  # include "incls/_vmError.cpp.incl"
  
 +# ifdef ZERO
-+# include <interpreterRuntime.hpp>
 +# include <stackPrinter_zero.hpp>
-+# endif //
++# endif // ZERO
 +
  // List of environment variables that should be reported in error log file.
  const char *env_list[] = {
diff -r 12f2a25cb831 -r f0c97fcc519f ports/hotspot/src/cpu/zero/vm/stackPrinter_zero.hpp
--- a/ports/hotspot/src/cpu/zero/vm/stackPrinter_zero.hpp	Thu May 21 14:26:47 2009 +0100
+++ b/ports/hotspot/src/cpu/zero/vm/stackPrinter_zero.hpp	Fri May 22 14:56:54 2009 +0100
@@ -23,6 +23,9 @@
  *
  */
 
+#include <interpreterRuntime.hpp>
+#include <scopeDesc.hpp>
+
 class ZeroStackPrinter {
  private:
   outputStream* _st;
@@ -190,15 +193,26 @@
         }
       }
       if (frame->is_shark_frame()) {
+        SharkFrame *sf = frame->as_shark_frame();
+        methodOop method = sf->method();
+          
         if (word == SharkFrame::pc_off) {
           field = "pc";
+          if (method->is_oop()) {
+            nmethod *code = method->code();
+            address pc = sf->pc();
+            if (code->pc_desc_at(pc)) {
+              SimpleScopeDesc ssd(code, pc);
+              snprintf(_buf, _buflen, PTR_FORMAT " (bci %d)", pc, ssd.bci());
+              value = _buf;
+            }
+          }
         }
         else if (word == SharkFrame::unextended_sp_off) {
           field = "unextended_sp";
         }
         else if (word == SharkFrame::method_off) {
           field = "method";
-          methodOop method = ((SharkFrame *) frame)->method();
           if (method->is_oop())
             value = method->name_and_sig_as_C_string(_buf, _buflen);
         }