OpenJDK7 and the JavaOne preview (M3) release

[Andrew John Hughes]

2009/5/24 Mark Wielaard <mark at klomp.org>:
> On Sat, 2009-05-23 at 09:18 +0200, Mark Wielaard wrote:
>> On Fri, 2009-05-22 at 20:05 +0200, Mark Wielaard wrote:
>> > On Fri, 2009-05-22 at 18:35 +0100, Andrew John Hughes wrote:
>> > > Are there any negative side-effects to having this code applied all the time?
>> >
>> > No, the patches are designed so that without the property set the old
>> > pipeline is used.
>>
>> That said, if you do build with --disable-xrender then the font issue
>> doesn't occur. So something else is broken with the xrender support :(
>> I propose that we disable xrender support by default for now while we
>> figure out what else is borked.
>
> Found it. The X11 pipeline initialization is a bit tricky to follow. The
> xrender patches tried to clear that up at one point by making the
> initialization of the X11SurfaceData explicit (just like the
> XRSurfaceData). Although that code is nicer and cleaner, the new font
> code depends on the implicit static initializer calling order. That is a
> bit yucky, but lets play along and make sure that no explicit
> initialization is done:
>
> 2009-05-24  Mark Wielaard  <mark at klomp.org>
>
>        * patches/xrender/icedtea-001.patch: Initialize X11SurfaceData
>        implicitly, not explicitly.
>
> Now both the standard X11 pipeline (default) and the XRender pipeline
> (-Dsun.java2d.xrender=True) work again against IcedTea7.
>
> Cheers,
>
> Mark
>

Thanks for finding and fixing this.  I narrowed it down to
X11SurfaceData on Friday (a diff between the non-xrender and xrender
versions showed this was the only place with a change that would make
any effect), but it was too late to find a fix.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8