changeset in /hg/icedtea: 2009-05-26 Matthias Klose <doko at ubun...

[Andrew John Hughes]

2009/5/27 Matthias Klose <doko at ubuntu.com>:
> Andrew John Hughes schrieb:
>> 2009/5/26  <doko at ubuntu.com>:
>
>> Huh? I already recreated the patch against 7 before I committed it.
>
> maybe. but did you try to build with it?
>

No and I see now that there are some differences in the types that
would cause it to break.  It would help if your ChangeLog comments
were a bit more descriptive; 'Update to OpenJDK7' just implies that
the patch was regenerated against the source, not that the code had to
be changed.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8