RFC: Netx - Check and store intial-heap-size and max-heap-size

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2009-05-26 13:53]:
> Hi,
>
> JNLP files can specify the initial heap size and the max heap size for  
> the JVM. NetX currently ignores these. The attached patch makes Netx  
> check that the values supplied in the JNLP file are correct, and store  
> them as strings to preserve the original values.
>
> ChangeLog:
> 2009-05-26  Omair Majid  <omajid at redhat.com>
>     * rt/net/sourceforge/jnlp/JREDesc.java: Change type of
>     initialHeapSize to String. Change type of maximumHeapSize to String.
>     (JREDesc): Check for sensible values for heap sizes.
>     (getMaximumHeapSize): Change return type to String.
>     (getInitialHeapSize): Likewise.
>     (heapToLong): Renamed to checkHeapSize.
>     (checkHeapSize): Check for valid heap size.
>     * rt/net/sourceforge/jnlp/resources/Messages.properties: Add
>     PBadHeapSize message to indicate an invalid heap size.
>
> Any comments?

Looks good.

Have you given any thought to how these values will be used by the way? The 
current design does not allow setting of heap sizes as the application 
code runs from the same vm instance as 'javaws' itself. You could make
it launch a new vm process I guess, but that'd be a bit messy, specially
since the security manager and stuff would need to be reset somehow,
which means the need for another wrapper..

Anyways, patch is good. Go ahead and commit any time.

Deepak

>
> Cheers,
> Omair
>