RFC: Loading animation for applets

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2009-05-27 13:31]:
> Hi,
>
> The attached patch adds an applet loading animation for IcedTeaPlugin to  
> icedtea6.
>
> The patch adds binary files (images). A mercurial bundle is available  
> from http://icedtea.classpath.org/~omajid/applet-loading-animation.hg.  
> (Use hg unbundle to apply it.)
>
> The main change is adding an animator class to NetxPanel. This  
> PluginAppetLoadingAnimator shows the animation in the panel until the  
> applet has initialized. To have the animator stop when the applet has  
> finished initializing, extra events have been added. All these events  
> are now sent by AppletPanel instead of NetxPanel since only AppletPanel  
> knows exactly what the state of the applet it.
>

I see you are patching AppletPanel. Can't this be done instead by
drawing the image in a panel added to the main applet panel via 
PluginAppletViewer? Changing upstream classes for the plugin should be
avoided unless absolutely necessary...

Deepak

> ChangeLog
> 2009-05-27  Omair Majid  <omajid at redhat.com>
>
>     * Makefile.am
>     (ICEDTEA_PATCHES): Apply applet patches.
>     (stamps/patch.stamp): Copy applet images over into resources/.
>     * patches/icedtea-applet-additional-events.patch: New file. Send
>     additional applet events. Send them from here instead of NetxPanel.
>     * patches/icedtea-applet-images.patch: New file. Fixes and creates
>     Makefiles to install the images into resources.jar.
>     * plugin/icedtea/sun/applet/PluginAppletLoadingAnimator.java: New
>     file. This class is responsible for showing the applet loading
>     animation.
>     * plugin/icedtea/sun/applet/resources/icedtea-background-*.jpeg:
>     Frames for the loading animation.
>     * plugin/icedtea/sun/applet/resources/icedtea-text.png: New file.
>     IcedTeaPlugin logo.
>     * rt/net/sourceforge/jnlp/NetxPanel.java: Add animator.
>     (NetxPanel): Initialize and add applet animator.
>     (runLoader): Dont send applet events. AppletPanel takes care of that
>     now.
>
> Any comments?
>
> Cheers,
> Omair