[patch] rfc: shark overloaded intrinsic suffix fix

[Gary Benson]

Push away :)

Cheers,
Gary

Xerxes Rånby wrote:
> I was toying with adding some optimization passes and verify passes to
> speed up and more runtime checks to shark, while doing so then one of
> the verify passes found at least one oddity in the shark sourcecode.
> The attached patch fixes this verifier issue.
> 
> verifier output:
> Overloaded intrinsic has incorrect suffix: '.i32'. It should be '.i32.p0i32'
> i32 (i32*, i32, i32)* @llvm.atomic.cmp.swap.i32
> Broken module found, compilation aborted!
> Stack dump:
> 0.    Running pass 'Module Verifier' on function
> '@"java.io.BufferedReader::readLine"'
> Avbruten (SIGABRT)
> 
> http://llvm.org/docs/LangRef.html#int_atomics
> 
> Ok to push?
> 
> Cheers
> Xerxes
> 

> Index: icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp
> ===================================================================
> --- icedtea6.orig/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp	2009-10-06 12:37:23.000000000 +0200
> +++ icedtea6/ports/hotspot/src/share/vm/shark/sharkBuilder.cpp	2009-10-06 12:54:11.000000000 +0200
>  -402,7 +402,7 @@
>  #ifdef ARM
>      (address) zero_cmpxchg_int,
>  #else
> -    "llvm.atomic.cmp.swap.i32",
> +    "llvm.atomic.cmp.swap.i32.p0i32",
>  #endif // ARM
>      "Iii", "i");
>  }
>  -422,7 +422,7 @@
>  #ifdef ARM
>      (address) zero_cmpxchg_ptr,
>  #else
> -    "llvm.atomic.cmp.swap.i" LP64_ONLY("64") NOT_LP64("32"),
> +    "llvm.atomic.cmp.swap.i" LP64_ONLY("64") NOT_LP64("32") ".p0i" LP64_ONLY("64") NOT_LP64("32"),
>  #endif // ARM
>      "Xxx", "x");
>  }


-- 
http://gbenson.net/