/hg/icedtea: 3 new changesets

[Matthias Klose]

On 17.11.2009 15:58, Andrew John Hughes wrote:
> 2009/11/17 Matthias Klose<doko at ubuntu.com>:
>> On 17.11.2009 13:44, andrew at icedtea.classpath.org wrote:
>>>
>>> changeset 9c090fa1a619 in /hg/icedtea
>>> details:
>>> http://icedtea.classpath.org/hg/icedtea?cmd=changeset;node=9c090fa1a619
>>> author: Andrew John Hughes<ahughes at redhat.com>
>>> date: Tue Nov 17 19:31:54 2009 +0000
>>>
>>>         Always checksum zips, even if specified with --with-alt-x.
>>
>> if I understand the patch correctly, then this is the wrong thing to do.
>> distributions need to ship modified tarballs with binary files and files
>> with questionalble licenses removed.
>>
>>   Matthias
>>
>
> Do we still have any?  If so, we should be getting them removed upstream.

is upstream willing to remove any prebuilt binaries from the tarballs?

> I don't think that's a justifiable reason to allow through potential
> bogus zips; this patch avoids issues where the build then fails
> because someone used an old zip.

I honestly disagree; did you see any cases where this did go wrong?

> Worst case, you can change the checksum to match your modified tarball.

If you really have to do this (which I disagree with), please only do this for 
tarballs which are not renamed, e.g. disable the check for anything which name 
differs from the "upstream" name.

   Matthias