HotSpot 16: Status

Thu Oct 29 02:31:00 PDT 2009

2009/10/29 Xerxes Rånby <xerxes at zafena.se>:
> Andrew John Hughes skrev:
>> Following my recent patches, I believe we now have HotSpot 16 working
>> for normal builds, Zero builds and Shark builds (fingers crossed).
>> Thanks to doko for reporting issues.
>>
>> Before we consider making it the default, I'd be interesting to know
>> if it works with:
>>
>> * Ed's ARM port
>> * Zero on other platforms (ARM, PPC)
>>
>> Gary, Ed, Xerces; could you take a look when you get chance?  Unlike
>> the Zero and Shark failures, we don't have a 'get out of jail free'
>> card for the ARM port by backporting fixes from IcedTea7!
>>
>> I'd personally like it to be the default before we ship a new release.
>>
> Hi Andrew
>
> I tried a clean build of zero+asm and hs16 using these configure options:
> ./configure --with-hotspot-build=hs16 --with-openjdk --disable-docs
>
> Unfortunally there seems to still be some problems with InlineSmallCode
> for openjdk6.
> $hg tip
> changeset:   1752:bbe2aacf72cc
> tag:         tip
> user:        Andrew John Hughes <ahughes at redhat.com>
> date:        Fri May 22 23:35:26 2009 +0100
> summary:     Fix the Shark build by defining InlineSmallCode.
>
>
> make[6]: Leaving directory
> `/ssd/icedtea6/openjdk/build/linux-arm/hotspot/outputdir/linux_zero_core/product'
> make[6]: Entering directory
> `/ssd/icedtea6/openjdk/build/linux-arm/hotspot/outputdir/linux_zero_core/product'
> echo Generating precompiled header incls/_precompiled.incl.gch
> Generating precompiled header incls/_precompiled.incl.gch
> mkdir -p ./incls
> g++ -DLINUX -D_GNU_SOURCE -DCC_INTERP -DZERO -DARM
> -DZERO_LIBARCH=\"arm\" -DPRODUCT -I. -I../generated/adfiles
> -I../generated/jvmtifiles
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/asm
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/c1
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/ci
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/classfile
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/code
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/compiler
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation/shared
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation/g1
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation/parallelScavenge
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation/concurrentMarkSweep
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_implementation/parNew
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/gc_interface
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/interpreter
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/memory
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/oops
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/prims
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/runtime
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/services
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/shark
> -I/ssd/icedtea6/openjdk/hotspot/src/share/vm/utilities
> -I/ssd/icedtea6/openjdk/hotspot/src/cpu/zero/vm
> -I/ssd/icedtea6/openjdk/hotspot/src/os/linux/vm
> -I/ssd/icedtea6/openjdk/hotspot/src/os_cpu/linux_zero/vm -I../generated
> -DHOTSPOT_RELEASE_VERSION="\"16.0-b10\""
> -DHOTSPOT_BUILD_TARGET="\"product\"" -DHOTSPOT_BUILD_USER="\"root\""
> -DHOTSPOT_LIB_ARCH=\"arm\" -DJRE_RELEASE_VERSION="\"1.6.0_0-b17\""
> -DHOTSPOT_VM_DISTRO="\"OpenJDK\"" -DDISTRIBUTION_ID="\"Built on Ubuntu
> 9.04\""  -fpic -fno-rtti -fno-exceptions -D_REENTRANT -fcheck-new  -pipe
> -g -O3 -fno-strict-aliasing -DHOTSPOT_ASM -DVM_LITTLE_ENDIAN -Werror
> -Wpointer-arith -Wsign-compare    -c -x c++-header -c
> ../generated/incls/_precompiled.incl -o incls/_precompiled.incl.gch
> In file included from ../generated/incls/_precompiled.incl:9:
> /ssd/icedtea6/openjdk/hotspot/src/share/vm/runtime/globals.hpp:50:
> error: redefinition of 'const intx pd_InlineSmallCode'
> /ssd/icedtea6/openjdk/hotspot/src/cpu/zero/vm/globals_zero.hpp:47:
> error: 'const intx pd_InlineSmallCode' previously defined here
> make[6]: *** [incls/_precompiled.incl.gch] Error 1
> make[6]: Leaving directory
> `/ssd/icedtea6/openjdk/build/linux-arm/hotspot/outputdir/linux_zero_core/product'
> make[5]: *** [the_vm] Error 2
> make[5]: Leaving directory
> `/ssd/icedtea6/openjdk/build/linux-arm/hotspot/outputdir/linux_zero_core/product'
> make[4]: *** [productcore] Error 2
> make[4]: Leaving directory
> `/ssd/icedtea6/openjdk/build/linux-arm/hotspot/outputdir'
> make[3]: *** [generic_buildcore] Error 2
> make[3]: Leaving directory `/ssd/icedtea6/openjdk/hotspot/make'
> make[2]: *** [productcore] Error 2
> make[2]: Leaving directory `/ssd/icedtea6/openjdk/hotspot/make'
> make[1]: *** [hotspot-build] Error 2
> make[1]: Leaving directory `/ssd/icedtea6/openjdk'
> make: *** [stamps/icedtea.stamp] Error 2
>
> real    261m55.920s
> user    131m8.370s
> sys    1m45.500s
>
> Cheers
> Xerxes
>

We just added this to fix the Shark build and I now recall this being
a problem before.  It seems there is a bit of history:

2009-05-22  Andrew John Hughes  <ahughes at redhat.com>

       * ports/hotspot/src/cpu/zero/vm/globals_zero.hpp:
       Define InlineSmallCode, using x86 value to begin with.

That's the fix I just added.

But it appears we then have:

       * ports/hotspot/src/cpu/zero/vm/globals_zero.hpp:
       Remove InlineSmallCode and...
       * ports/hotspot/src/cpu/zero/vm/shark_globals_zero.hpp:
       ...add it here, only needed for Shark builds.

Which is the fix I would otherwise guess we want to add to IcedTea6.  But then
globals_zero.hpp as committed to upstream has it globals_zero.hpp
again:

       * ports/hotspot/src/cpu/zero/vm/shark_globals_zero.hpp:
       Drop InlineSmallCode as in globals_zero.hpp upstream.

Which obviously works as we've tested it plenty.  So I wonder what the
heck is going on?  Gary, can you shed any light on this?
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8