RFC: Patch to correct pulse-java.jar build

[jon.vanalten at redhat.com]

Thanks for the comments.

----- "Andrew John Hughes" <gnu_andrew at member.fsf.org> wrote:

> 
> The definitions:
> 
[snip]
> 
> seem to end up writing to the source directory
> (PULSE_JAVA_NATIVE_BUILDDIR =
> $(abs_top_srcdir)/pulseaudio/build/native and PULSE_JAVA_CLASS_DIR =
> $(abs_top_srcdir)/pulseaudio/build/cp).  That's incorrect and will
> break make distcheck.  The build directories should be in
> subdirectories of $(abs_top_builddir).  Making PULSE_JAVA_BUILDDIR =
> $(abs_top_builddir)/pulseaudio would fix that.
> 

Whoops, thanks for pointing that out.
(fixed in both patches.)

> The IcedTea7 patch also reintroduces conditionals on ICEDTEA_BOOT_DIR
> and the corresponding duplicating javac/jar invocations..  Please
> don't do this.  These were removed deliberately and will also be
> removed from IcedTea6 once I port over
> $(INITIAL_BOOTSTRAP_LINK_STAMP).  The new JAVAC definitions also drop
> IT_JAVACFLAGS, completely reverting it to the IcedTea6 version.
> 

Oh.  Hadn't realized this.  Far be it from me to undo others' work!  Thank goodness for reviews.  :-D
(reverted relevant portions of icedtea7 patch)

The patch for icedtea6 also includes a couple of small edits to the EXTRA_DIST definitions that were breaking distcheck.  Does this look better Andrew?

Actually, distcheck is still broken in icedtea6 afaics even with these fixes, but I haven't figured out how to fix.  To be specific, when it does 'rm -rf lib' a bunch of files in lib/rt/net/sourceforge/jnlp/resources/ resist removal with Permission denied errors.  This rm call is within the target

  distcheck: && $(MAKE) $(AM_MAKEFLAGS) distcleancheck: distclean: distclean-am: distclean-local

(ie it's in the distclean-local target, but that is the target chain leading to it.)  The resources directory for whatever reason (this is what I haven't figured out) has 555 permissions, although its parents all seem to have 775.  I've reproduced this twice on my F11 system.  Does anyone have any ideas why this might be?

cheers,

jon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pulse6.patch
Type: text/x-patch
Size: 8106 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090922/ac36038e/pulse6.patch 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pulse7.patch
Type: text/x-patch
Size: 5353 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20090922/ac36038e/pulse7.patch