RFC: Shark calling static jni method jclass argument fix

Xerxes Rånby xerxes at zafena.se
Thu Apr 22 02:25:09 PDT 2010


On 2010-04-22 09:53, Gary Benson wrote:
> Xerxes Ranby wrote:
>   
>> When Shark jits code that calls static jni methods then the jvm
>> bombs if the static jni code tries to use the passed jclass
>> argument.
>>     
> ...
>   
>> The attached patch fix!
>>     
> Good catch!
>
>   
>> ok to commit?
>>     
> Can you make it:
>
>   target()->method_holder()->klass_part()->java_mirror()
>
> The two are equivalent, but nothing in Shark should reference the
> constants pool directly.
>
> Cheers,
> Gary
>
>   

Thank you for the code review Gary!
Commited with the suggested change to:
http://icedtea.classpath.org/hg/icedtea6/rev/67bc1a7196b8

Cheers,
Xerxes



More information about the distro-pkg-dev mailing list