[RFC] backport opentype font support from openjdk6 to icedtea6 1.9

[Dr Andrew John Hughes]

On 10:40 Tue 10 Aug     , Omair Majid wrote:
> On 08/10/2010 10:20 AM, Dr Andrew John Hughes wrote:
> > On 09:38 Tue 10 Aug     , Omair Majid wrote:
> >> On 08/10/2010 05:43 AM, Dr Andrew John Hughes wrote:
> >>> On 22:55 Mon 09 Aug     , Dr Andrew John Hughes wrote:
> >>>> On 10:09 Mon 09 Aug     , Omair Majid wrote:
> >>>>> Hi,
> >>>>>
> >>>>> I would like to backport OpenType font support from OpenJDK6 to
> >>>>> Icedtea6-1.9. Patches corresponding to the following two changesets will
> >>>>> need to be added to icedtea6:
> >>>>>
> >>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/b577c70564b8
> >>>>> http://hg.openjdk.java.net/jdk6/jdk6/jdk/rev/acb763ebef95
> >>>>>
> >>>>> Any thoughts?
> >>>>>
> >>>>> Cheers,
> >>>>> Omair
> >>>>
> >>>> Sounds sensible.  Please note that patches for 1.9 require approval on
> >>>> the list before commit.  I presume you are also going to commit this to
> >>>> HEAD as well.
> >>>>
> >>
> >> Or we could wait until the next OpenJDK6 build and automatically acquire
> >> the patch that way. I am not in any hurry about committing it to head -
> >> as long as HEAD gets the patch before the next release (1.10?)
> >>
> >
> > I'd prefer it went in ASAP so it could receive testing.  My
> > trepidation with respect to 1.9 is that it hasn't really received much
> > testing so far.  It sounds like a sensible fix to basically just
> > remove some code that is preventing FreeType being fully used.
> > However, I'd rather we tried it in HEAD for a bit first, and then
> > thought about adding it to the release branches if no issues arise.
> >
> > We also don't know what the timeline is for b21.  This is already
> > supported by the icedtea6-hg branch so the patch can simply be dropped
> > again from there.
> >
> >>>> Backports should be stored in patches/openjdk/<bugid>-<summary>.patch
> >>>> for ease of removal when they appear upstream.
> >>>>
> >>>> Does this fix any bugs in the IcedTea or Red Hat bugzilla as well?
> >>>>
> >>
> >> Yes, it fixes https://bugzilla.redhat.com/show_bug.cgi?id=525870. Not
> >> completely - x11 native fonts are still not supported - but it does make
> >> Java report many more fonts on the system
> >>
> >
> > Good.  Please make sure that both this bug and the Oracle bug ID are mentioned
> > in NEWS.
> >
> >>>> Thanks,
> >>>> --
> >>>> Andrew :)
> >>>>
> >>>> Free Java Software Engineer
> >>>> Red Hat, Inc. (http://www.redhat.com)
> >>>>
> >>>> Support Free Java!
> >>>> Contribute to GNU Classpath and the OpenJDK
> >>>> http://www.gnu.org/software/classpath
> >>>> http://openjdk.java.net
> >>>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> >>>> Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
> >>>
> >>> Having now reviewed the changesets, I don't think this is suitable for 1.9
> >>> as it seems to add a new feature rather than fixing a bug, making significant
> >>> changes to TTorT1Filter to do so.  Is there a specific reason for wanting it
> >>> in 1.9?
> >>>
> >>
> >> Yes. Please see the bugzilla link I posted above.
> >>
> >>> The native changes only apply to Windows platforms.  Does this actually
> >>> change things on GNU/Linux systems?
> >>>
> >>
> >> Surprisingly, it does. OpenJDK uses freetype which already supports
> >> OpenType fonts [1]. Before this patch was put in, the JDK would say that
> >> OpenType fonts are not supported and not even try to let freetype handle
> >> OpenType fonts.
> >>
> >
> > There may be another part to the patch we can't see; adding support to
> > their proprietary backend.  Another reason for testing this is that
> > only OpenJDK uses FreeType and so testing of FreeType with OpenType
> > fonts is likely to be limited.
> >
> 
> Ok. Combined with the above, I am taking it to mean that I should commit 
> this to HEAD but not to 1.9 until we have tested it out for a while.
> 

Yes.  Let's review the situation for 1.9.1.

> >> Cheers,
> >> Omair
> >>
> >> [1] http://freetype.sourceforge.net/freetype2/index.html#features
> >
> > Thanks,
> 

Cheers,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8