[RFC] netx: dont try to render null images

[Dr Andrew John Hughes]

On 13:26 Mon 16 Aug     , Omair Majid wrote:
> Hi,
> 
> The current splash screen code for Netx has a bug where it tries to 
> display an image even if the image was not read successfully. The patch 
> checks if the image is null and skips drawing the splash screen in that 
> case.
> 
> Any comments?
> 
> Cheers,
> Omair

> diff -r c73c4672031a netx/net/sourceforge/jnlp/JNLPSplashScreen.java
> --- a/netx/net/sourceforge/jnlp/JNLPSplashScreen.java	Tue Aug 10 14:52:56 2010 -0400
> +++ b/netx/net/sourceforge/jnlp/JNLPSplashScreen.java	Mon Aug 16 13:08:34 2010 -0400
> @@ -44,6 +44,12 @@
>          try {
>              splashImage = ImageIO.read(resourceTracker
>                      .getCacheFile(splashImageUrl));
> +            if (splashImage == null) {
> +                if (JNLPRuntime.isDebug()) {
> +                    System.err.println("Error loading splash image: " + url);
> +                }
> +                return;
> +            }
>          } catch (IOException e) {
>              if (JNLPRuntime.isDebug()) {
>                  System.err.println("Error loading splash image: " + url);


Seems like a sensible fix to me.  Approved for HEAD, 1.7, 1.8 and 1.9 (assuming it affects all of them).

Thanks,
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8