[icedtea-web] RFC: Allow 1.7 & 1.8 as build JDKs
Dr Andrew John Hughes
ahughes at redhat.com
Wed Dec 1 08:10:44 PST 2010
On 18:31 Tue 30 Nov , Deepak Bhole wrote:
> * Dr Andrew John Hughes <ahughes at redhat.com> [2010-11-30 18:15]:
> > On 16:52 Tue 30 Nov , Deepak Bhole wrote:
> > > * Dr Andrew John Hughes <ahughes at redhat.com> [2010-11-30 16:51]:
> > > > Simple patch attached. It moves NETX_DIR to the front of the bootclasspath
> > > > so that the NetX classes in existing 1.7 and 1.8 installations don't get in the
> > > > way of the newer versions just built. Ok to apply?
> > > >
> > > > *NOTE*: You still are unable to install the final IcedTea-Web product in that JDK.
> > > > I think the launcher needs to prepend them to the bootclasspath to override the
> > > > rt.jar versions.
> > >
> > > Looks fine to me.. missing ChangeLog entry though, which I assume you
> > > will add before commit :)
> > >
> > > Okay for HEAD with a CL entry.
> > >
> >
> > Yes, done. I just fired off the patch quickly because I was discussing it with Omair
> > on IRC and assumed he would give a quick ack. But seems not.
> >
> > Thanks for doing so.
> >
>
> I reviewed it within seconds of getting it actually.. mail is taking
> forever to get through though :(
>
Ah right. Next time I'll cc you for icedtea-web patches.
> Cheers,
> Deepak
>
> > > Cheers,
> > > Deepak
> > >
> > > > --
> > > > Andrew :)
> > > >
> > > > Free Java Software Engineer
> > > > Red Hat, Inc. (http://www.redhat.com)
> > > >
> > > > Support Free Java!
> > > > Contribute to GNU Classpath and the OpenJDK
> > > > http://www.gnu.org/software/classpath
> > > > http://openjdk.java.net
> > > > PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> > > > Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
> > >
> > > > diff -r b1409d2cbd86 Makefile.am
> > > > --- a/Makefile.am Tue Nov 30 16:53:16 2010 +0000
> > > > +++ b/Makefile.am Tue Nov 30 20:57:41 2010 +0000
> > > > @@ -220,8 +220,7 @@
> > > > mkdir -p $(abs_top_builddir)/liveconnect && \
> > > > $(BOOT_DIR)/bin/javac $(IT_JAVACFLAGS) \
> > > > -d $(abs_top_builddir)/liveconnect \
> > > > - -classpath $(NETX_DIR) \
> > > > - -bootclasspath $(RUNTIME) \
> > > > + -bootclasspath $(NETX_DIR):$(RUNTIME) \
> > > > -sourcepath $(LIVECONNECT_SRCS) \
> > > > @liveconnect-source-files.txt ; \
> > > > fi
> > >
> >
> > --
> > Andrew :)
> >
> > Free Java Software Engineer
> > Red Hat, Inc. (http://www.redhat.com)
> >
> > Support Free Java!
> > Contribute to GNU Classpath and IcedTea
> > http://www.gnu.org/software/classpath
> > http://icedtea.classpath.org
> > PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
> > Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
--
Andrew :)
Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)
Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA 7927 142C 2591 94EF D9D8
More information about the distro-pkg-dev
mailing list