[icedtea-web] RFC: add desktop file for itweb-settings

[Dr Andrew John Hughes]

On 16:47 Wed 01 Dec     , Omair Majid wrote:
> Hi,
> 
> The attached patch adds a desktop entry file to allow users to start 
> itweb-settings from a GUI (like Gnome's System->Preferences menu).
> 
> ChangeLog:
> 2010-12-01  Omair Majid  <omajid at redhat.com>
> 
>    * Makefile.am (EXTRA_DIST): Add itweb-settings.desktop.in.
>    (all-local): Add itweb-settings.desktop.
>    (clean-desktop-files): Remove itweb-settings.desktop.
>    (itweb-settings.desktop): New target.
>    * itweb-settings.desktop.in: New file.
> 
> Cheers,
> Omair

Looks good, though I'd add a line break in the itweb-settings.desktop file sed invocation to
make it clearer.   Please commit with that change.

> diff -r 9035fbdbd6e7 Makefile.am
> --- a/Makefile.am	Wed Dec 01 16:14:51 2010 -0500
> +++ b/Makefile.am	Wed Dec 01 16:33:58 2010 -0500
> @@ -84,13 +84,14 @@
>  	-Wl,\$$ORIGIN/../jre/lib/$(INSTALL_ARCH_DIR)/jli $(X11_CFLAGS) $(X11_LIBS) -ljli  -ldl -lz
>  PLUGIN_VERSION = IcedTea $(PACKAGE_VERSION)$(ICEDTEA_REV)$(ICEDTEA_PKG)
>  
> -EXTRA_DIST = $(top_srcdir)/netx $(top_srcdir)/plugin javaws.png javaws.desktop.in extra launcher
> +EXTRA_DIST = $(top_srcdir)/netx $(top_srcdir)/plugin javaws.png javaws.desktop.in extra launcher \
> + itweb-settings.desktop.in
>  
>  # Top-Level Targets
>  # =================
>  
>  all-local: stamps/netx-dist.stamp extra-lib/about.jar stamps/plugin.stamp $(NETX_DIR)/launcher/javaws \
> - javaws.desktop stamps/docs.stamp $(NETX_DIR)/launcher/controlpanel/itweb-settings
> + javaws.desktop stamps/docs.stamp $(NETX_DIR)/launcher/controlpanel/itweb-settings itweb-settings.desktop
>  
>  clean-local: clean-netx clean-plugin clean-liveconnect clean-extra clean-bootstrap-directory \
>   clean-native-ecj clean-desktop-files clean-docs
> @@ -293,6 +294,7 @@
>  
>  clean-desktop-files:
>  	rm -f javaws.desktop
> +	rm -f itweb-settings.desktop
>  
>  # extras -- used to create about.jar for javaws.
>  extra-source-files.txt:
> @@ -339,6 +341,9 @@
>  javaws.desktop: javaws.desktop.in
>  	sed "s#PATH_TO_JAVAWS#$(DESTDIR)$(bindir)/javaws#" < $(srcdir)/javaws.desktop.in > javaws.desktop
>  
> +itweb-settings.desktop: itweb-settings.desktop.in
> +	sed "s#PATH_TO_ITWEB_SETTINGS#$(DESTDIR)$(bindir)/itweb-settings#" < $(srcdir)/itweb-settings.desktop.in > itweb-settings.desktop
> +
>  # documentation
>  
>  stamps/docs.stamp: stamps/netx-docs.stamp stamps/plugin-docs.stamp
> diff -r 9035fbdbd6e7 itweb-settings.desktop.in
> --- /dev/null	Thu Jan 01 00:00:00 1970 +0000
> +++ b/itweb-settings.desktop.in	Wed Dec 01 16:33:58 2010 -0500
> @@ -0,0 +1,8 @@
> +[Desktop Entry]
> +Name=IcedTea Web Control Panel
> +Comment=Configure IcedTea Web
> +Exec=PATH_TO_ITWEB_SETTINGS
> +Icon=javaws
> +Terminal=false
> +Type=Application
> +Categories=Settings;


-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and IcedTea
http://www.gnu.org/software/classpath
http://icedtea.classpath.org
PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint = F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8