[icedtea-web] RFC: Formatting fixes for Java code

Deepak Bhole dbhole at redhat.com
Mon Dec 6 12:36:48 PST 2010

* Omair Majid <omajid at redhat.com> [2010-12-06 12:11]:
> On 12/03/2010 06:26 PM, Deepak Bhole wrote:
> >Hi,
> >
> >In the interest of starting off right with 1.0, here is a patch that
> >fixes formatting for all of the .java files in IcedTea Web. The
> >formatting was fixed through eclipse, and the settings files used are
> >included in the attached tarball. I intend to check those in as well.
> >
> >There is now a section on the wiki that specifies standard formatting:
> >http://icedtea.classpath.org/wiki/IcedTea-Web#Code_style
> >
> Thanks for adding the section and posting the example.
> >This patch only fixes whitespace/indentation. It does not change any
> >code (or comment content). It also does not alter line wrapping.
> >
> I looked over the patch, and everything looks good to me.
> >To be on the safe side, I did a rudimentary bytecode comparison of
> >compiled classes before (tip) and after (tip + this patch). The code is
> >identical.
> >
> That's good to know. Anyway, I am fine with the changes. Please go
> ahead and commit.

Thanks for reviewing! I've committed the changes.


> Cheers,
> Omair

More information about the distro-pkg-dev mailing list