[icedtea-web] RFC: remove version check when parsing jnlp files
Omair Majid
omajid at redhat.com
Wed Dec 8 09:13:06 PST 2010
On 12/08/2010 10:46 AM, Deepak Bhole wrote:
> * Omair Majid<omajid at redhat.com> [2010-12-08 10:44]:
>> Hi,
>>
>> The attached patch removes the explicit check for jnlp spec version
>> when parsing a JNLP file.
>>
>> A number of JNLP files that I have come across contain invalid spec
>> number - the only valid spec numbers that I know of are 1.0, 1.5 and
>> 6.0 (and updates). If Netx encounters a spec number that it does not
>> recognize, it current fails by throwing a ParseException. Over the
>> years, more and more spec numbers were added as "supported" in order
>> to be compatible with JNLP files that were perfectly valid but
>> contained an invalid spec number. With this patch, I am removing
>> this check: Netx will attempt to run all JNLP files without looking
>> at the spec number.
>>
>> This patch is for HEAD only.
>>
>
> OK for HEAD.
>
Thanks for the review. Pushed as changeset 78afe7c627ae.
Cheers,
Omair
More information about the distro-pkg-dev
mailing list