[icedtea-web] RFC: add support for validating the deployment configuration

[Omair Majid]

Hi,

The attached patch adds support for validating the deployment 
configuration. This patch does not add any GUI or command line tools to 
do it manually (that will be addressed later).

What this patch does is reject invalid values in all deployment 
configuration files and use the default ones. A deployment.properties 
file like:
deployment.debug=foobar
deployment.user.cachedir=file:///localhost/
foo.bar=foo

will make javaws detect the problems and use the default values instead:

Unknown setting "deployment.debug"
Unknown setting "foo.bar"
Error: setting "deployment.user.cachedir" has incorrect value 
"file:///localhost/". Using the default value 
"/home/omajid/.icedtea/cache" instead. Possible values include the 
absolute location of a file - it must begin with a /.

ChangeLog:
2010-12-09  Omair Majid  <omajid at redhat.com>

     * netx/net/sourceforge/jnlp/config/ValueValidator.java: New file.
     * netx/net/sourceforge/jnlp/config/BasicValueValidators.java: New
     file. Provides methods to get some common validators.
     * netx/net/sourceforge/jnlp/config/ConfiguratonValidator.java: New
     file. Provides methods to validate a configuration.
     * netx/net/sourceforge/jnlp/runtime/DeploymentConfiguration.java:
     Moved to config subpackage instead and split off into Setting.java,
     DeploymentConfiguration.java and Defaults.java.
     * netx/net/sourceforge/jnlp/config/DeploymentConfiguration.java:
     Renamed version of original DeploymentConfiguration.
     (load): Delegate to load.
     (load(boolean)): Load configuration and optionally fix any issues
     found.
     (checkAndFixConfiguration): New method. Validate all settings and
     set them to default values if problems found.
     * netx/net/sourceforge/jnlp/config/Setting.java: New file. Based on
     ConfigValue which was originally a part of DeploymentConfiguration.
     * netx/net/sourceforge/jnlp/config/Defaults.java: New file.
     Contains the default configuration settings. Originally from
     DeploymentConfiguration.java's loadDefaultProperties.
     * netx/net/sourceforge/jnlp/resources/Messages.properties: Add new
     messages.
     * netx/net/sourceforge/jnlp/Launcher.java: Fix imports.
     * netx/net/sourceforge/jnlp/SecurityDesc.java: Likewise.
     * netx/net/sourceforge/jnlp/cache/CacheUtil.java: Likewise.
     * netx/net/sourceforge/jnlp/controlpanel
     /AdvancedProxySettingsDialog.java: Likewise
     * netx/net/sourceforge/jnlp/controlpanel
     /AdvancedProxySettingsPane.java: Likewise.
     * netx/net/sourceforge/jnlp/controlpanel/ControlPanel.java: Likewise
     * netx/net/sourceforge/jnlp/controlpanel/DebuggingPanel.java:
     Likewise.
     * netx/net/sourceforge/jnlp/controlpanel/DesktopShortcutPanel.java:
     Likewise.
     * netx/net/sourceforge/jnlp/controlpanel/MiddleClickListener.java:
     Likewise
     * netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java:
     Likewise.
     * netx/net/sourceforge/jnlp/controlpanel/SecuritySettingsPanel.java:
     Likewise.
     * netx/net/sourceforge/jnlp/controlpanel
     /TemporaryInternetFilesPanel.java:Likewise.
     * netx/net/sourceforge/jnlp/runtime/ApplicationInstance.java:
     Likewise.
     * netx/net/sourceforge/jnlp/runtime/JNLPProxySelector.java:
     Likewise.
     * netx/net/sourceforge/jnlp/runtime/JNLPRuntime.java: Likewise.
     * netx/net/sourceforge/jnlp/security/KeyStores.java: Likewise.
     * netx/net/sourceforge/jnlp/security/SecurityWarning.java: Likewise.
     * netx/net/sourceforge/jnlp/services/ServiceUtil.java: Likewise.
     * netx/net/sourceforge/jnlp/services/SingleInstanceLock.java:
     Likewise.
     * netx/net/sourceforge/jnlp/services/XBasicService.java: Likewise
     * netx/net/sourceforge/jnlp/services/XPersistenceService.java:
     Likewise.
     * netx/net/sourceforge/jnlp/util/XDesktopEntry.java: Likewise.
     * plugin/icedteanp/java/sun/applet/JavaConsole.java: Likewise.
     * plugin/icedteanp/java/sun/applet/PluginMain.java: Likewise.

Thoughts or comments?

Cheers,
Omair
-------------- next part --------------
A non-text attachment was scrubbed...
Name: validate-settings-02.patch
Type: text/x-patch
Size: 111389 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101209/cdcc210f/validate-settings-02.patch