[RFC][Icedtea-web] Add cache viewer for control panel.

[Andrew Su]

----- "Andrew Su" <asu at redhat.com> wrote:
--Snip--
> > Overall, it looks fine. But I do have a few suggestions on how it
> can
> > be 
> > improved:
> > 
> > - Please update the patch so it builds with current HEAD. All that
> is
> > 
> > required is changing the imports from
> > import net.sourceforge.jnlp.runtime.DeploymentConfiguration;
> > to
> > import net.sourceforge.jnlp.config.DeploymentConfiguration;
> > 
> > - Please make the cache viewer window resizable. It's quite hard to
> > see 
> > the full path and the full domain without changing the window size.
> Will change these two.
> 
> > 
> > - The size column doesn't specify the units of the size (is that
> > bytes?)
> Whoops.
> 
> > 
> > - I would like to be able to sort by columns.
> Okay, I'll add to updated patch.
> 
> > 
> > - Some javadoc comments seem to diverge from the code style
> guidelines
> > 
> > [1] without good reason. Please fix that.
> This was unintentional, ctrl+shift+f in eclipse using the settings
> file from tip still made it line wrap for me, will fix manually.
> 
> > 
> > - Is there a reason you use Vectors rather than ArrayLists? Vectors
> 
> > synchronize all of their operations, which is going to be slower.
> Before posting I had it generate the data in add components then
> passed in the data and column to the instructor for JTable to
> populate, it doesn't accept ArrayList. I will change it to use
> ArrayList for the updated patch.
> 
> > 
> > - Can you split out methods that traverse the cache from this cache
> 
> > viewer? It might be more appropriate to create a new class in 
> > net.sourceforge.jnlp.cache for this.
> Sure thing!
> 
> Thanks for looking it over!
> 
> Regards,
>   Andrew
> 

Hello,

All these changes have now been added + fixed in this updated patch.

Changelog:

Added a cache viewer for the control panel.
* netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java:
(addComponents): Changed buttons to open cache viewer.
* netx/net/sourceforge/jnlp/resources/Messages.properties: Added text used by the cache viewer
* netx/net/sourceforge/jnlp/cache/CacheDirectory.java,
netx/net/sourceforge/jnlp/cache/DirectoryNode.java,
netx/net/sourceforge/jnlp/controlpanel/CachePane.java,
netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java: New classes.

Questions? Comments? Concerns?

Cheers,
  Andrew

> > 
> > Thanks,
> > Omair
> > 
> > [1] http://icedtea.classpath.org/wiki/IcedTea-Web#Code_style
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 20101215_add_cache_viewer.patch
Type: text/x-patch
Size: 2481 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/distro-pkg-dev/attachments/20101215/b11a440d/20101215_add_cache_viewer.patch