/hg/icedtea-web: Remove creation of swing thread for displaying ...

[asu at icedtea.classpath.org]

changeset ea073a7dafa1 in /hg/icedtea-web
details: http://icedtea.classpath.org/hg/icedtea-web?cmd=changeset;node=ea073a7dafa1
author: Andrew Su <asu at redhat.com>
date: Thu Dec 23 16:45:37 2010 -0500

	Remove creation of swing thread for displaying dialogs.


diffstat:

5 files changed, 24 insertions(+), 38 deletions(-)
ChangeLog                                                               |   11 +++++
netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java |   19 +++-------
netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java                 |    3 -
netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java        |   14 ++-----
netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java |   15 -------

diffs (122 lines):

diff -r 70e445bbe85a -r ea073a7dafa1 ChangeLog
--- a/ChangeLog	Wed Dec 22 17:14:44 2010 -0500
+++ b/ChangeLog	Thu Dec 23 16:45:37 2010 -0500
@@ -1,3 +1,14 @@ 2010-12-22  Deepak Bhole <dbhole at redhat.
+2010-12-23  Andrew Su  <asu at redhat.com>
+
+	* netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java:
+	(showAdvancedProxySettingsDialog): Removed creation of swing thread.
+	* netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java:
+	(showCacheDialog): Removed throwing of exception.
+	* netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java:
+	(addComponents): Removed try catch block.
+	* /netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java:
+	(addComponents): Removed creation of swing thread and try catch block.
+
 2010-12-22  Deepak Bhole <dbhole at redhat.com>
 
 	RH665104: OpenJDK Firefox Java plugin loses a cookie
diff -r 70e445bbe85a -r ea073a7dafa1 netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java
--- a/netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java	Wed Dec 22 17:14:44 2010 -0500
+++ b/netx/net/sourceforge/jnlp/controlpanel/AdvancedProxySettingsDialog.java	Thu Dec 23 16:45:37 2010 -0500
@@ -116,21 +116,14 @@ public class AdvancedProxySettingsDialog
      * 
      * @param config
      *            A loaded DeploymentConfiguration file.
-     * @throws Exception
      */
-    public static void showAdvancedProxySettingsDialog(final DeploymentConfiguration config) throws Exception {
+    public static void showAdvancedProxySettingsDialog(final DeploymentConfiguration config) {
         setSystemLookAndFeel();
-        SwingUtilities.invokeLater(new Runnable() {
-            @Override
-            public void run() {
-                AdvancedProxySettingsDialog psd = new AdvancedProxySettingsDialog(config);
-                psd.setResizable(false);
-                psd.centerDialog();
-                psd.setVisible(true);
-                psd.dispose();
-            }
-        });
-
+        AdvancedProxySettingsDialog psd = new AdvancedProxySettingsDialog(config);
+        psd.setResizable(false);
+        psd.centerDialog();
+        psd.setVisible(true);
+        psd.dispose();
     }
 
     /**
diff -r 70e445bbe85a -r ea073a7dafa1 netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java
--- a/netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java	Wed Dec 22 17:14:44 2010 -0500
+++ b/netx/net/sourceforge/jnlp/controlpanel/CacheViewer.java	Thu Dec 23 16:45:37 2010 -0500
@@ -89,9 +89,8 @@ public class CacheViewer extends JDialog
      * Display the cache viewer.
      * 
      * @param config Configuration file.
-     * @throws Exception
      */
-    public static void showCacheDialog(final DeploymentConfiguration config) throws Exception {
+    public static void showCacheDialog(final DeploymentConfiguration config) {
         CacheViewer psd = new CacheViewer(config);
         psd.setResizable(true);
         psd.centerDialog();
diff -r 70e445bbe85a -r ea073a7dafa1 netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java
--- a/netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java	Wed Dec 22 17:14:44 2010 -0500
+++ b/netx/net/sourceforge/jnlp/controlpanel/NetworkSettingsPanel.java	Thu Dec 23 16:45:37 2010 -0500
@@ -115,22 +115,18 @@ public class NetworkSettingsPanel extend
         JLabel portLabel = new JLabel(Translator.R("NSPort") + ":");
         final JTextField addressField = new JTextField(config.getProperty(properties[1]), 10);
         addressField.getDocument().addDocumentListener(new DocumentAdapter(config, properties[1]));
-        
+
         final JTextField portField = new JTextField(config.getProperty(properties[2]), 3);
         portField.getDocument().addDocumentListener(new DocumentAdapter(config, properties[1]));
-        
+
         // Create the button which allows setting of other types of proxy.
         JButton advancedProxyButton = new JButton(Translator.R("NSAdvanced") + "...");
         advancedProxyButton.addActionListener(new ActionListener() {
             @Override
             public void actionPerformed(ActionEvent e) {
-                try {
-                    AdvancedProxySettingsDialog.showAdvancedProxySettingsDialog(config);
-                    addressField.setText(config.getProperty(properties[1]));
-                    portField.setText(config.getProperty(properties[2]));
-                } catch (Exception e1) {
-                    e1.printStackTrace();
-                }
+                AdvancedProxySettingsDialog.showAdvancedProxySettingsDialog(config);
+                addressField.setText(config.getProperty(properties[1]));
+                portField.setText(config.getProperty(properties[2]));
             }
         });
 
diff -r 70e445bbe85a -r ea073a7dafa1 netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java
--- a/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java	Wed Dec 22 17:14:44 2010 -0500
+++ b/netx/net/sourceforge/jnlp/controlpanel/TemporaryInternetFilesPanel.java	Thu Dec 23 16:45:37 2010 -0500
@@ -184,23 +184,10 @@ public class TemporaryInternetFilesPanel
         JPanel buttonDeleteRestore = new JPanel(new FlowLayout(FlowLayout.TRAILING));
         JButton bViewFiles = new JButton(Translator.R("TIFPViewFiles"));
         bViewFiles.addActionListener(new ActionListener() {
-
             @Override
             public void actionPerformed(ActionEvent e) {
-                SwingUtilities.invokeLater(new Runnable() {
-                    @Override
-                    public void run() {
-                        try {
-                            CacheViewer.showCacheDialog(config);
-                        } catch (Exception e1) {
-                            // TODO Auto-generated catch block
-                            e1.printStackTrace();
-                        }
-
-                    }
-                });
+                CacheViewer.showCacheDialog(config);
             }
-
         });
         buttonDeleteRestore.add(bViewFiles);