Request to commit: to icedtea6-1.7 release

[Edward Nevill]

Hi,

Matthias has reported problems with JTreg failing with "Unimplemented opcode = 230".

I have been unable to replicate the problem locally.

Opcode 230 is 'dmac', double multiply and accumulate. This is an optimisation for dmul, followed by dadd.

I propose for the 1.7 release simply removing this opcode altogether. I will leave it in the trunk for the moment until we can work out exactly what it going on with this opccode.

I am currently doing a complete rebuild with this change applied. I will not know the results until tomorrow.

Attached are the diffs. OK to commit? Should I commit it now or wait for the results of the rebuild tomorrow morning?

Regards,
Ed.

--- CUT HERE -------------------------------------------
diff -ruNE orig/icedtea6-1.7/ports/hotspot/src/cpu/zero/vm/bytecodes_arm.def new/icedtea6-1.7/ports/hotspot/src/cpu/zero/vm/bytecodes_arm.def
--- orig/icedtea6-1.7/ports/hotspot/src/cpu/zero/vm/bytecodes_arm.def	2010-01-12 09:36:48.000000000 +0000
+++ new/icedtea6-1.7/ports/hotspot/src/cpu/zero/vm/bytecodes_arm.def	2010-01-12 09:45:15.000000000 +0000
@@ -267,7 +267,7 @@
 
 @return_register_finalizer = 0xe5, 1
 
-dmac			= 0xe6, 2
+ at dmac			= 0xe6, 2
 
 iload_0_iconst_N        = 0xe7, 2
 iload_1_iconst_N        = 0xe8, 2
@@ -2455,10 +2455,10 @@
 }
 
 (dmul) dmul_vfp {
-	FBC	cmp	r2, #opc_dadd
+@	FBC	cmp	r2, #opc_dadd
 	DISPATCH_START_R2
-	FBC	beq	1f
-2:
+@	FBC	beq	1f
+ at 2:
 	vldr	d7, [stack, #12]
 	vldr	d6, [stack, #4]
 	DISPATCH_NEXT
@@ -2469,30 +2469,30 @@
 	vstr	d0, [stack, #12]
 	add	stack, stack, #8
 	DISPATCH_FINISH
-1:
-	FBC	mov	r2, #opc_dmac
-	FBC	strb	r2, [jpc, #-1]
-	FBC	b	2b
-}
-
-#ifdef FAST_BYTECODES
-
-(dmac) dmac_vfp {
-	DISPATCH_START	\seq_len
-	vldr	d2, [stack, #20]
-	vldr	d1, [stack, #12]
-	vldr	d0, [stack, #4]
-	DISPATCH_NEXT
-	DISPATCH_NEXT
-	fmacd	d2, d1, d0
-	DISPATCH_NEXT
-	DISPATCH_NEXT
-	vstr	d2, [stack, #20]
-	add	stack, stack, #16
-	DISPATCH_FINISH
-}
-
-#endif // FAST_BYTECODES
+ at 1:
+@	FBC	mov	r2, #opc_dmac
+@	FBC	strb	r2, [jpc, #-1]
+@	FBC	b	2b
+}
+
+@#ifdef FAST_BYTECODES
+@
+@(dmac) dmac_vfp {
+@	DISPATCH_START	\seq_len
+@	vldr	d2, [stack, #20]
+@	vldr	d1, [stack, #12]
+@	vldr	d0, [stack, #4]
+@	DISPATCH_NEXT
+@	DISPATCH_NEXT
+@	fmacd	d2, d1, d0
+@	DISPATCH_NEXT
+@	DISPATCH_NEXT
+@	vstr	d2, [stack, #20]
+@	add	stack, stack, #16
+@	DISPATCH_FINISH
+@}
+@
+@#endif // FAST_BYTECODES
 
 (fdiv) fdiv_vfp {
 	DISPATCH_START_R2
@@ -10013,32 +10013,32 @@
 	DISPATCH_BYTECODE
 }
 
-#ifdef HW_FP
-
-(dmac)(dastore) {
-	ldr	tmp2, [stack, #28]
-	ldr	tmp1, [stack, #32]
-	vldr	d2, [stack, #20]
-	vldr	d1, [stack, #12]
-	vldr	d0, [stack, #4]
-	DISPATCH_START	\seq_len
-	SW_NPC	cmp	tmp1, #0
-	SW_NPC	beq	null_ptr_exception
-.abortentry120:
-	ldr	ip, [tmp1, #8]
-	cmp	tmp2, ip
-	DISPATCH_NEXT
-	bcs	array_bound_exception_jpc_1_tmp2
-	DISPATCH_NEXT
-	add	tmp2, tmp1, tmp2, lsl #3
-	fmacd	d2, d1, d0
-	vstr	d2, [tmp2, #BASE_OFFSET_LONG]
-	DISPATCH_NEXT
-	DISPATCH_NEXT
-	add	stack, stack, #32
-	DISPATCH_FINISH
-}
-
-#endif //HW_FP
+@#ifdef HW_FP
+@
+@(dmac)(dastore) {
+@	ldr	tmp2, [stack, #28]
+@	ldr	tmp1, [stack, #32]
+@	vldr	d2, [stack, #20]
+@	vldr	d1, [stack, #12]
+@	vldr	d0, [stack, #4]
+@	DISPATCH_START	\seq_len
+@	SW_NPC	cmp	tmp1, #0
+@	SW_NPC	beq	null_ptr_exception
+ at .abortentry120:
+@	ldr	ip, [tmp1, #8]
+@	cmp	tmp2, ip
+@	DISPATCH_NEXT
+@	bcs	array_bound_exception_jpc_1_tmp2
+@	DISPATCH_NEXT
+@	add	tmp2, tmp1, tmp2, lsl #3
+@	fmacd	d2, d1, d0
+@	vstr	d2, [tmp2, #BASE_OFFSET_LONG]
+@	DISPATCH_NEXT
+@	DISPATCH_NEXT
+@	add	stack, stack, #32
+@	DISPATCH_FINISH
+@}
+@
+@#endif //HW_FP
 
 #endif // FAST_BYTECODES