Patch for review: Adding default value to certain attributes

[Deepak Bhole]

* Man Wong <mwong at redhat.com> [2010-01-15 17:36]:
> This patch allows netx to not cause a failure when the codebase and href attribute under the jnlp tag is missing (codebase and href are not required attributes, hence missing them should not cause an exception to be thrown). 
> 
> Changelog:
> 2010-01-15  Man Lung Wong <mwong at redhat.com>
>     
>          * rt/net/sourceforge/jnlp/JNLPFile.java
>          (parse): Added a default value for sourceLocation to make sure it is not null
>                   (location is never null).
> 
>          * rt/net/sourceforge/jnlp/Parser.java
>                   Removed variable base, and replaced it with codebase. The fix ended 
>                   with base the same as codebase, hence no longer needed. Otherwise, 
>                   netx will launch a jnlp file with codebase null and href not null 
>                   (not the way sun's webstart behaves).
>           
>          * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
>          (setSecurity): Added a variable codebase, which gets the value of codebase
>                         attribute in the jnlp file if it exists. Otherwise, it gets
>                         the value of the location of main jar resource (which needs
>                         to be changed to the codebase portion instead of the entire
>                         location). 
>                                
> Any comments?
> 

Just for the sake of consistency here, the lines in ChangeLog shouldn't
be multiply indented. If it overflows on to the next line, it should
start at the same spot as the line above. i.e.


          * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
          (setSecurity): Added a variable codebase, which gets the value of codebase
                         attribute in the jnlp file if it exists. Otherwise, it gets
                         the value of the location of main jar resource (which needs
                         to be changed to the codebase portion instead of the entire
                         location). 

Should be:

    * rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
    (setSecurity): Added a variable codebase, which gets the value of codebase
    attribute in the jnlp file if it exists. Otherwise, it gets the value of 
    the location of main jar resource (which needs to be changed to the codebase 
    portion instead of the entire location).

...
...

<snip>

> diff -r 9e6623803599 rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java
> --- a/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Wed Jan 13 19:32:07 2010 -0500
> +++ b/rt/net/sourceforge/jnlp/runtime/JNLPClassLoader.java	Thu Jan 14 14:21:46 2010 -0500
> @@ -167,6 +167,16 @@
>      }
>  
>      private void setSecurity() {
> +		
> +        URL codebase = null;
> +
> +		if (file.getCodeBase() != null) {
> +			codebase = file.getCodeBase();
> +		} else {

The function appears to have indenting issues. The first line is
indented, the rest aren't.. it should be consistent with the rest of the
function body.

Other than that, the rest looks fine. Assuming you have tested it,
please fix the above and commit any time.

Cheers,
Deepak