1.7 and NPPlugin

[Andrew John Hughes]

2010/1/22 Deepak Bhole <dbhole at redhat.com>:
> * Andrew John Hughes <gnu_andrew at member.fsf.org> [2010-01-21 09:05]:
>> I thought we were ready to ship 1.7.  But then I tried to build NPPlugin...
>>
>> cd /var/tmp/portage/dev-java/icedtea6-1.7/work/icedtea6-1.7/plugin/icedteanp; \
>>         if [ -e
>> /var/tmp/portage/dev-java/icedtea6-1.7/work/icedtea6-1.7/.hg ] &&
>> which /usr/bin/hg >/dev/null; then \
>>           revision="-r`(cd
>> /var/tmp/portage/dev-java/icedtea6-1.7/work/icedtea6-1.7; /usr/bin/hg
>> tip --template '{rev}')`" ; \
>
>
> Hmm, it builds fine for me on rawhide.
>
> Can you retry with the attached patch?
>
> Deepak
>
>>         fi ; \
>>         if [ -n "1.7" ]; then plugin_version=" (1.7)"; fi; \
>>         plugin_version=" 1.7$revision$plugin_version"; \
>>         powerpc-unknown-linux-gnu-g++ -O2 -mtune=G5 -mcpu=G5
>> -mabi=altivec -pipe -ggdb \
>>           -DPACKAGE_VERSION="\"1.7\"" \
>>           -DPLUGIN_VERSION="\"$plugin_version\"" \
>>           -DMOZILLA_VERSION_COLLAPSED="1090011" \
>>           -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   \
>>           -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
>> -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
>> -\
>> I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
>> -I/usr/include/pixman-1 -I/usr/include/freetype2
>> -I/usr/include/libpng12   \
>>           -fshort-wchar -I/usr/include/xulrunner-1.9/stable
>> -I/usr/include/nspr   \
>>           -fPIC -c IcedTeaNPPlugin.cc IcedTeaScriptablePluginObject.cc
>> IcedTeaJavaRequestProcessor.cc IcedTeaPluginRequestProcesso\
>> r.cc IcedTeaPluginUtils.cc; \
>>         cd ../
>> In file included from IcedTeaJavaRequestProcessor.h:46,
>>                  from IcedTeaScriptablePluginObject.h:49,
>>                  from IcedTeaNPPlugin.cc:51:
>> IcedTeaNPPlugin.h:43:27: error: nsThreadUtils.h: No such file or directory
>> IcedTeaNPPlugin.cc:56:31: error: nsIPluginInstance.h: No such file or directory
>> IcedTeaNPPlugin.cc:57:35: error: nsIPluginInstancePeer.h: No such file
>> or directory
>> IcedTeaNPPlugin.cc:58:31: error: nsIPluginTagInfo2.h: No such file or directory
>> IcedTeaNPPlugin.cc:62:30: error: nsICookieService.h: No such file or directory
>> IcedTeaNPPlugin.cc:63:26: error: nsIDNSRecord.h: No such file or directory
>> IcedTeaNPPlugin.cc:64:27: error: nsIDNSService.h: No such file or directory
>> IcedTeaNPPlugin.cc:65:24: error: nsINetUtil.h: No such file or directory
>> IcedTeaNPPlugin.cc:66:26: error: nsIProxyInfo.h: No such file or directory
>> IcedTeaNPPlugin.cc:67:37: error: nsIProtocolProxyService.h: No such
>> file or directory
>> IcedTeaNPPlugin.cc:68:38: error: nsIScriptSecurityManager.h: No such
>> file or directory
>> IcedTeaNPPlugin.cc:71:22: error: nsNetCID.h: No such file or directory
>> etc.
>>
>> but worst of all it doesn't fail then but goes on to do the entire
>> second OpenJDK build (another few hours on ppc) and then fails after
>> that!
>>
>> Shouldn't it be checking for this stuff during configure?
>>
>> On my x86_64 box, I don't even get through configure:
>>
>> checking for xulrunner version... configure: error: in
>> `/mnt/builder/icedtea6-1.7':
>> configure: error: cannot determine xulrunner version
>> --
>> Andrew :-)
>>
>> Free Java Software Engineer
>> Red Hat, Inc. (http://www.redhat.com)
>>
>> Support Free Java!
>> Contribute to GNU Classpath and the OpenJDK
>> http://www.gnu.org/software/classpath
>> http://openjdk.java.net
>>
>> PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
>> Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8
>

That changed nothing, but the following made the x86_64 build complete:

-  CPPFLAGS="$CPPFLAGS $XULRUNNER_CFLAGS"
+  CPPFLAGS="$CPPFLAGS $XULRUNNER_CFLAGS $MOZILLA_CFLAGS"

I'm not sure what effect the MOZILLA_CFLAGS being added will have
though, especially on other platforms.  I've only built it, not
tested.  Will the plugin work with Chromium 4.0.288.1?  If so, I'll
try the new Gentoo ebuild for it and test the plugin with it.  How it
got to 4.0 already I have no idea!

I think the ppc issue is that there is no version test (there is a
>1.9 on old plugin, but nothing on new).  The ppc box is using
1.9.0.11 which may be too old.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8