Plugin crashes with Xulrunner 1.9.2/libpng/libjpeg

[Andrew John Hughes]

2010/1/22 Andreas Radke <a.radke at arcor.de>:
> I'm building for ArchLinux the packages. We are currently updating libpng and libjpeg
> at once and need to rebuild/fix openjdk.
> When I understand it right with new xulrunner 1.9.2 it's no more possible to build the old
> plugin (configure passed but the build quickly fails).
>
> With npplugin I get this:
> checking for XULRUNNER... configure: error: Package requirements (      nspr mozilla-js mozilla-plugin libxul-unstable >= 1.9) were not met:
>
> No package 'libxul-unstable' found
>
> I have to apply sed -i "s/libxul-unstable/libxul/" configure.ac to pass configure.

This should now build, and npplugin will be automatically enabled for
xulrunner >= 1.9.2.

> The pkg builds fine then but as soon as the plugin is called the browsers gives a segfault.
>
> Checking with ldd /usr/lib/mozilla/plugins/IcedTeaNPPlugin.so gives:
>        libxul.so => not found
>        libxpcom.so => not found
> How does that come?
>

No idea, the plugin works here with 1.9.2.

>
>
> Something else: I have to apply this for the new libpng 1.4.0:
>
> -- openjdk/jdk/src/share/native/sun/awt/splashscreen/splashscreen_png.c 2010-01-22 16:40:55.984689900 +0000
> +++ openjdk/jdk/src/share/native/sun/awt/splashscreen/splashscreen_png.c.new    2010-01-22 16:59:25.450412461 +0000
> @@ -182,7 +182,7 @@
>     int success = 0;
>
>     stream->read(stream, sig, SIG_BYTES);
> -    if (!png_check_sig(sig, SIG_BYTES)) {
> +    if (png_sig_cmp(sig, 0, SIG_BYTES)) {
>         goto done;
>     }
>     success = SplashDecodePng(splash, my_png_read_stream, stream);
>

Patched in 1.7.

> I hope this is the proper change to replace the deprecated function and not causing the trouble.
> The function is also called here but I don't know how f it is has to be changed there:
> [andyrtr at workstation64 trunk]$  grep -r png_check_sig src/*
> src/icedtea6/openjdk/jdk/src/share/native/sun/awt/libpng/png.h: * png_check_sig(sig, n) := !png_sig_cmp(sig, 0, n).
> src/icedtea6/openjdk/jdk/src/share/native/sun/awt/libpng/png.h:extern PNG_EXPORT(int,png_check_sig) PNGARG((png_bytep sig, int num));
> src/icedtea6/openjdk/jdk/src/share/native/sun/awt/libpng/png.c:png_check_sig(png_bytep sig, int num)
> src/icedtea6/openjdk/jdk/src/share/native/sun/awt/libpng/CHANGES:  Changed libpng.txt to demonstrate png_sig_cmp() instead of
>

There's only one call.  The OpenJDK sources include an old version of
libpng that IcedTea doesn't use.

> and we will have to find fixes for libjpeg ver 8. Is there already something floating around?

Fixed in 1.7.

>
> -Andy
>



-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8