[Bug 517] PulseAudio capture issue

[bugzilla-daemon at icedtea.classpath.org]

http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=517


jon.vanalten at redhat.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|unassigned at icedtea.classpath|jon.vanalten at redhat.com
                   |.org                        |
             Status|NEW                         |ASSIGNED




------- Comment #1 from jon.vanalten at redhat.com  2010-07-07 14:32 -------
Created an attachment (id=387)
 --> (http://icedtea.classpath.org/bugzilla/attachment.cgi?id=387&action=view)
Fixes unnecessary exception throwing.

The attached patch resolves the issues exposed by this example, among others.

open() calls on an open line still throw an exception, as per
<Target|Source>DataLine interface API.

close() calls on an closed line should not throw an exception, but rather
become no-ops.

read() or write() calls on a closed line should not throw an exception, but
rather should return 0 bytes read or written.  This is supported by API
documentation as well:
"However, if the data line is closed, stopped, drained, or flushed before the
requested amount has been <read|written>, the method no longer blocks, but
returns the number of bytes <read|written> thus far."

drain() calls on a closed line are explicitly allowed by the API:
"This method always returns when the data line is closed."

flush() on an open line is not mentioned in the API, but throwing an exception
seemed unnecessary so I changed it so that the stream was flushed only if the
line was open.

I've also changed the checks for open to use the isOpen() public API method
rather than the protected variable.


-- 
Configure bugmail: http://icedtea.classpath.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
You are the assignee for the bug, or are watching the assignee.