/hg/icedtea6: Eliminate spurious exception throwing in PulseAudi...
vanaltj at icedtea.classpath.org
vanaltj at icedtea.classpath.org
Mon Jul 12 08:16:24 PDT 2010
changeset e35661d7528d in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=e35661d7528d
author: Jon VanAlten <jon.vanalten at redhat.com>
date: Mon Jul 12 11:13:35 2010 -0400
Eliminate spurious exception throwing in PulseAudio provider.
2010-07-12 Jon VanAlten <jon.vanalten at redhat.com>
* pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataL
ine.java
* pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.
java
* pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourc
eDataLine.java
* pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTarge
tDataLine.java: Eliminate spurious exception throwing from
open, close, read, write, drain, and flush calls on closed
lines. Use isOpen() API call instead of instance variable
where appropriate.
diffstat:
5 files changed, 86 insertions(+), 77 deletions(-)
ChangeLog | 9 +
pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java | 29 +--
pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.java | 6
pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java | 36 +---
pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java | 83 +++++-----
diffs (369 lines):
diff -r 867af494861c -r e35661d7528d ChangeLog
--- a/ChangeLog Thu Jul 08 15:54:35 2010 -0400
+++ b/ChangeLog Mon Jul 12 11:13:35 2010 -0400
@@ -1,3 +1,12 @@ 2010-07-08 Man Lung Wong <mwong at redhat
+2010-07-12 Jon VanAlten <jon.vanalten at redhat.com>
+ * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java
+ * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.java
+ * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java
+ * pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java:
+ Eliminate spurious exception throwing from open, close, read, write,
+ drain, and flush calls on closed lines.
+ Use isOpen() API call instead of instance variable where appropriate.
+
2010-07-08 Man Lung Wong <mwong at redhat.com>
* netx/net/sourceforge/jnlp/Parser.java:
diff -r 867af494861c -r e35661d7528d pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java
--- a/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java Thu Jul 08 15:54:35 2010 -0400
+++ b/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioDataLine.java Mon Jul 12 11:13:35 2010 -0400
@@ -86,7 +86,7 @@ abstract class PulseAudioDataLine extend
protected void open(AudioFormat format, int bufferSize)
throws LineUnavailableException {
- if (isOpen) {
+ if (isOpen()) {
throw new IllegalStateException("Line is already open");
}
@@ -139,7 +139,7 @@ abstract class PulseAudioDataLine extend
}
}
- if (!isOpen) {
+ if (!isOpen()) {
throw new IllegalArgumentException("Invalid format");
}
@@ -299,9 +299,10 @@ abstract class PulseAudioDataLine extend
@Override
public void close() {
- if (!isOpen) {
- throw new IllegalStateException(
- "Line must be open for close() to work");
+ if (!isOpen()) {
+ // For whatever reason, we are being asked to close
+ // a line that is not even open.
+ return;
}
synchronized (eventLoop.threadLock) {
@@ -346,7 +347,7 @@ abstract class PulseAudioDataLine extend
@Override
public void start() {
- if (!isOpen) {
+ if (!isOpen()) {
throw new IllegalStateException(
"Line must be open()ed before it can be start()ed");
}
@@ -376,10 +377,10 @@ abstract class PulseAudioDataLine extend
@Override
public synchronized void stop() {
- if (!isOpen) {
- throw new IllegalStateException(
- "Line must be open()ed before it can be start()ed");
-
+ if (!isOpen()) {
+ // For some reason, we are being asked to stop a line
+ // that isn't even open.
+ return;
}
writeInterrupted = true;
if (!isStarted) {
@@ -433,7 +434,7 @@ abstract class PulseAudioDataLine extend
throws LineUnavailableException;
public Stream getStream() {
- if (!isOpen) {
+ if (!isOpen()) {
throw new IllegalStateException("Line must be open");
}
@@ -442,7 +443,7 @@ abstract class PulseAudioDataLine extend
@Override
public int getBufferSize() {
- if (!isOpen) {
+ if (!isOpen()) {
return DEFAULT_BUFFER_SIZE;
}
return bufferSize;
@@ -450,7 +451,7 @@ abstract class PulseAudioDataLine extend
@Override
public AudioFormat getFormat() {
- if (!isOpen) {
+ if (!isOpen()) {
return defaultFormat;
}
return currentFormat;
@@ -467,7 +468,7 @@ abstract class PulseAudioDataLine extend
* the name of this audio stream
*/
public void setName(String streamName) {
- if (isOpen) {
+ if (isOpen()) {
Operation o;
synchronized (eventLoop.threadLock) {
diff -r 867af494861c -r e35661d7528d pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.java
--- a/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.java Thu Jul 08 15:54:35 2010 -0400
+++ b/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioLine.java Mon Jul 12 11:13:35 2010 -0400
@@ -62,7 +62,7 @@ abstract class PulseAudioLine implements
@Override
public void close() {
- if (!isOpen) {
+ if (!isOpen()) {
throw new IllegalStateException("Line is not open");
}
@@ -79,7 +79,7 @@ abstract class PulseAudioLine implements
@Override
public Control getControl(Type control) {
- if (isOpen) {
+ if (isOpen()) {
for (Control aControl : controls) {
if (aControl.getType() == control) {
return aControl;
@@ -92,7 +92,7 @@ abstract class PulseAudioLine implements
@Override
public Control[] getControls() {
- if (!isOpen) {
+ if (!isOpen()) {
return new Control[] {};
}
diff -r 867af494861c -r e35661d7528d pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java
--- a/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java Thu Jul 08 15:54:35 2010 -0400
+++ b/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioSourceDataLine.java Mon Jul 12 11:13:35 2010 -0400
@@ -142,8 +142,9 @@ public final class PulseAudioSourceDataL
writeInterrupted = false;
}
- if (!isOpen) {
- throw new IllegalStateException("must call open() before write()");
+ if (!isOpen()) {
+ // A closed line can write exactly 0 bytes.
+ return 0;
}
int frameSize = currentFormat.getFrameSize();
@@ -259,11 +260,6 @@ public final class PulseAudioSourceDataL
@Override
public void drain() {
- if (!isOpen) {
- throw new IllegalStateException(
- "Line must be open before it can be drain()ed");
-
- }
synchronized (this) {
writeInterrupted = true;
@@ -271,13 +267,13 @@ public final class PulseAudioSourceDataL
do {
synchronized (this) {
- if (!isOpen) {
+ if (!isOpen()) {
return;
}
if (getBytesInBuffer() == 0) {
return;
}
- if (isStarted || !isOpen) {
+ if (isStarted) {
break;
}
try {
@@ -301,29 +297,27 @@ public final class PulseAudioSourceDataL
@Override
public void flush() {
- if (!isOpen) {
- throw new IllegalStateException(
- "Line must be open before it can be flush()ed");
- }
synchronized (this) {
writeInterrupted = true;
}
- Operation operation;
- synchronized (eventLoop.threadLock) {
- operation = stream.flush();
+ if (isOpen()) {
+ Operation operation;
+ synchronized (eventLoop.threadLock) {
+ operation = stream.flush();
+ }
+
+ operation.waitForCompletion();
+ operation.releaseReference();
}
-
- operation.waitForCompletion();
- operation.releaseReference();
}
@Override
synchronized public void close() {
- if (!isOpen) {
- throw new IllegalStateException("not open so cant close");
+ if (!isOpen()) {
+ return;
}
writeInterrupted = true;
diff -r 867af494861c -r e35661d7528d pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java
--- a/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java Thu Jul 08 15:54:35 2010 -0400
+++ b/pulseaudio/src/java/org/classpath/icedtea/pulseaudio/PulseAudioTargetDataLine.java Mon Jul 12 11:13:35 2010 -0400
@@ -76,14 +76,18 @@ public final class PulseAudioTargetDataL
@Override
synchronized public void close() {
+ if (!isOpen()) {
+ // Probably due to some programmer error, we are being
+ // asked to close an already closed line. Oh well.
+ Debug.println(DebugLevel.Verbose,
+ "PulseAudioTargetDataLine.close(): "
+ + "Line closed that wasn't open.");
+ return;
+ }
+
/* check for permission to record audio */
AudioPermission perm = new AudioPermission("record", null);
perm.checkGuard(null);
-
- if (!isOpen) {
- throw new IllegalStateException(
- "Line cant be closed if it isnt open");
- }
PulseAudioMixer parentMixer = PulseAudioMixer.getInstance();
parentMixer.removeTargetLine(this);
@@ -101,7 +105,7 @@ public final class PulseAudioTargetDataL
AudioPermission perm = new AudioPermission("record", null);
perm.checkGuard(null);
- if (isOpen) {
+ if (isOpen()) {
throw new IllegalStateException("already open");
}
super.open(format, bufferSize);
@@ -142,8 +146,9 @@ public final class PulseAudioTargetDataL
/* check state and inputs */
- if (!isOpen) {
- throw new IllegalStateException("must call open() before read()");
+ if (!isOpen()) {
+ // A closed line can produce zero bytes of data.
+ return 0;
}
int frameSize = currentFormat.getFrameSize();
@@ -220,7 +225,7 @@ public final class PulseAudioTargetDataL
while (remainingLength != 0) {
synchronized (this) {
- if (!isOpen || !isStarted) {
+ if (!isOpen() || !isStarted) {
return sizeRead;
}
@@ -287,57 +292,57 @@ public final class PulseAudioTargetDataL
@Override
public void drain() {
- if (!isOpen) {
- throw new IllegalStateException("must call open() before drain()");
+ // blocks when there is data on the line
+ // http://www.jsresources.org/faq_audio.html#stop_drain_tdl
+ while (true) {
+ synchronized (this) {
+ if (!isStarted || !isOpen()) {
+ break;
+ }
+ }
+ try {
+ //TODO: Is this the best length of sleep?
+ //Maybe in case this loop runs for a long time
+ //it would be good to switch to a longer
+ //sleep. Like bump it up each iteration after
+ //the Nth iteration, up to a MAXSLEEP length.
+ Thread.sleep(100);
+ } catch (InterruptedException e) {
+ // do nothing
+ }
}
synchronized (this) {
drained = true;
}
- // blocks when there is data on the line
- // http://www.jsresources.org/faq_audio.html#stop_drain_tdl
- while (true) {
- synchronized (this) {
- if (!isStarted || !isOpen) {
- break;
- }
- }
- try {
- Thread.sleep(100);
- } catch (InterruptedException e) {
- // do nothing
- }
- }
-
}
@Override
public void flush() {
- if (!isOpen) {
- throw new IllegalStateException("Line must be open");
+ if (isOpen()) {
+
+ /* flush the buffer on pulseaudio's side */
+ Operation operation;
+ synchronized (eventLoop.threadLock) {
+ operation = stream.flush();
+ }
+ operation.waitForCompletion();
+ operation.releaseReference();
}
-
- /* flush the buffer on pulseaudio's side */
- Operation operation;
- synchronized (eventLoop.threadLock) {
- operation = stream.flush();
- }
- operation.waitForCompletion();
- operation.releaseReference();
synchronized (this) {
flushed = true;
/* flush the partial fragment we stored */
fragmentBuffer = null;
}
-
}
@Override
public int available() {
- if (!isOpen) {
- throw new IllegalStateException("Line must be open");
+ if (!isOpen()) {
+ // a closed line has 0 bytes available.
+ return 0;
}
synchronized (eventLoop.threadLock) {
More information about the distro-pkg-dev
mailing list