/hg/icedtea6: Restore icedtea-override-metacity.patch to allow f...

[vanaltj at icedtea.classpath.org]

changeset 5719610f7230 in /hg/icedtea6
details: http://icedtea.classpath.org/hg/icedtea6?cmd=changeset;node=5719610f7230
author: Jon VanAlten <jon.vanalten at redhat.com>
date: Thu Jul 15 11:05:34 2010 -0400

	Restore icedtea-override-metacity.patch to allow full screen apps
	and other expected behavioral improvements.

	2010-07-14 Jon VanAlten <jon.vanalten at redhat.com>
	        * patches/icedtea-override-redirect-metacity.patch: Produces the
	"expected" behavior for full screen applications or other situations
	where developers wish to present elements that would cover things
	like panels.
	        * Makefile.am: Apply icedtea-override-redirect-metacity.patch.


diffstat:

3 files changed, 28 insertions(+), 1 deletion(-)
ChangeLog                                        |   15 +++++++++++++++
Makefile.am                                      |    3 ++-
patches/icedtea-override-redirect-metacity.patch |   11 +++++++++++

diffs (50 lines):

diff -r 0b656f7601bd -r 5719610f7230 ChangeLog
--- a/ChangeLog	Wed Jul 14 17:42:26 2010 -0400
+++ b/ChangeLog	Thu Jul 15 11:05:34 2010 -0400
@@ -1,3 +1,18 @@ 2010-07-14  Deepak Bhole <dbhole at redhat.
+2010-07-14  Jon VanAlten  <jon.vanalten at redhat.com>
+	* patches/icedtea-override-redirect-metacity.patch: Produces the
+	"expected" behavior for full screen applications or other situations
+	where developers wish to present elements that would cover things like
+	panels.  We previously had a version of this patch since changeset 876
+	ebc064e8892d, but dropped it in changeset changeset 1731
+	83619682858e because upstream had rejected as a metacity bug[1].
+	Metacity maintains that this behavior does not break any spec and does
+	not appear likely to change either[2], so we must be the "good guys" and
+	provide the expected behavior.  See discussion[3].
+	[1] http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6514512
+	[2] https://bugzilla.gnome.org/show_bug.cgi?id=405269
+	[3] http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2010-April/008862.html
+	* Makefile.am: Apply icedtea-override-redirect-metacity.patch.
+
 2010-07-14  Deepak Bhole <dbhole at redhat.com>
 
 	* plugin/icedteanp/java/sun/applet/PluginMessageConsumer.java: Add a new
diff -r 0b656f7601bd -r 5719610f7230 Makefile.am
--- a/Makefile.am	Wed Jul 14 17:42:26 2010 -0400
+++ b/Makefile.am	Thu Jul 15 11:05:34 2010 -0400
@@ -279,7 +279,8 @@ ICEDTEA_PATCHES = \
 	patches/shark-debug-option.patch \
 	patches/openjdk/6961732.patch \
 	patches/debug-dir.patch \
-	patches/no-sync.patch
+	patches/no-sync.patch \
+	patches/icedtea-override-redirect-metacity.patch
 
 if WITH_RHINO
 ICEDTEA_PATCHES += \
diff -r 0b656f7601bd -r 5719610f7230 patches/icedtea-override-redirect-metacity.patch
--- /dev/null	Thu Jan 01 00:00:00 1970 +0000
+++ b/patches/icedtea-override-redirect-metacity.patch	Thu Jul 15 11:05:34 2010 -0400
@@ -0,0 +1,11 @@
+--- openjdk/jdk/src/solaris/classes/sun/awt/X11/XWindowPeer.java.orig	2008-05-25 17:31:31.000000000 +0200
++++ openjdk/jdk/src/solaris/classes/sun/awt/X11/XWindowPeer.java	2008-05-25 17:33:32.000000000 +0200
+@@ -1124,6 +1124,8 @@
+ 
+     boolean isOverrideRedirect() {
+         return (XWM.getWMID() == XWM.OPENLOOK_WM ? true : false) ||
++            (XWM.getWMID() == XWM.METACITY_WM ? true : false) ||
++            target.getName().equals("###overrideRedirect###") ||
+             ((XToolkit)Toolkit.getDefaultToolkit()).isOverrideRedirect((Window)target) ||
+             XTrayIconPeer.isTrayIconStuffWindow((Window)target);
+     }