RFC: Get configure and make BUILD_DIR in sync

[Dr Andrew John Hughes]

On 20 July 2010 15:58, Mark Wielaard <mjw at redhat.com> wrote:
> Hi,
>
> The tapset.in files were using a hardcoded BUILD_DIR location at
> configure time. This broke slightly when the make changed the BUILD_DIR
> location (to openjdk.build). That was only an issue if you build without
> --with-abs-install-dir and tried using the systemtap tapsets "in place".
>
> The following patch makes it so that we have the same view of the
> BUILD_DIR at configure and make time.
>
> 2010-07-19  Mark Wielaard  <mjw at redhat.com>
>
>    * configure.ac (OPENJDK_BUILD_DIR): New AC_SUBST variable.
>    (with-abs-install-dir): Based on OPENJDK_BUILD_DIR when not given.
>    * Makefile.am (BUILD_DIR): Set to @OPENJDK_BUILD_DIR at .
>
> OK to commit & push?
>
> Thanks,
>
> Mark
>

Looks ok to me.  You could also replace the invocation of pwd with
${abs_top_builddir} to match usage elsewhere.

Thanks for catching this.  I build with abs-install-dir set and wasn't
aware it was possible to do otherwise.
-- 
Andrew :-)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Support Free Java!
Contribute to GNU Classpath and the OpenJDK
http://www.gnu.org/software/classpath
http://openjdk.java.net

PGP Key: 94EFD9D8 (http://subkeys.pgp.net)
Fingerprint: F8EF F1EA 401E 2E60 15FA  7927 142C 2591 94EF D9D8