[RFC] PR491 npplugin: pass java_{code,codebase,archive} paramters to java side

[Deepak Bhole]

* Omair Majid <omajid at redhat.com> [2010-07-20 11:55]:
> Hi,
> 
> The attached patch fixes IcedTea bug 491 "NPPlugin fails loading
> http://java.sun.com/products/java-media/2D/samples/suite/index.html
> Plugin pages" [1]. The java side is prepared to handle java_* tags
> but only in the original <embed> tag sent by the plugin, not in the
> <param> tags (see PluginAppletViewer.parse for the implementation
> details). So instead of passing the java_* parameters as a <param>
> this patch makes sure its passed along as part of the <embed> tag.
> 
> In case of duplicates, the java side of the plugin picks java_code
> over code, java_codebase over codebase and so on.
> 
> Any comments?
> 

Looks fine to me. Please commit to HEAD as well as 1.7 and 1.8

Cheers,
Deepak

> Cheers,
> Omair
> 
> [1] http://icedtea.classpath.org/bugzilla/show_bug.cgi?id=491

> diff -r 16b019555725 plugin/icedteanp/IcedTeaNPPlugin.cc
> --- a/plugin/icedteanp/IcedTeaNPPlugin.cc	Tue Jul 20 09:35:12 2010 -0400
> +++ b/plugin/icedteanp/IcedTeaNPPlugin.cc	Tue Jul 20 11:15:54 2010 -0400
> @@ -1625,6 +1625,13 @@
>            g_free (code);
>            code = NULL;
>      }
> +      else if (!g_ascii_strcasecmp (argn[i], "java_code"))
> +    {
> +          gchar* java_code = g_strdup_printf ("JAVA_CODE=\"%s\" ", argv[i]);
> +          applet_tag = g_strconcat (applet_tag, java_code, NULL);
> +          g_free (java_code);
> +          java_code = NULL;
> +    }
>        else if (!g_ascii_strcasecmp (argn[i], "codebase"))
>      {
>            gchar* codebase = g_strdup_printf ("CODEBASE=\"%s\" ", argv[i]);
> @@ -1632,6 +1639,13 @@
>            g_free (codebase);
>            codebase = NULL;
>      }
> +      else if (!g_ascii_strcasecmp (argn[i], "java_codebase"))
> +    {
> +          gchar* java_codebase = g_strdup_printf ("JAVA_CODEBASE=\"%s\" ", argv[i]);
> +          applet_tag = g_strconcat (applet_tag, java_codebase, NULL);
> +          g_free (java_codebase);
> +          java_codebase = NULL;
> +    }
>        else if (!g_ascii_strcasecmp (argn[i], "classid"))
>      {
>            gchar* classid = g_strdup_printf ("CLASSID=\"%s\" ", argv[i]);
> @@ -1646,6 +1660,13 @@
>            g_free (archive);
>            archive = NULL;
>      }
> +      else if (!g_ascii_strcasecmp (argn[i], "java_archive"))
> +    {
> +          gchar* java_archive = g_strdup_printf ("JAVA_ARCHIVE=\"%s\" ", argv[i]);
> +          applet_tag = g_strconcat (applet_tag, java_archive, NULL);
> +          g_free (java_archive);
> +          java_archive = NULL;
> +    }
>        else if (!g_ascii_strcasecmp (argn[i], "width"))
>      {
>            gchar* width = g_strdup_printf ("width=\"%s\" ", argv[i]);